But I am not sure why I got the message below. I don't have enough
expertise to review a patch to unity-2d (I don't know the codebase).
best,
Paulo
On Tue, Feb 21, 2012 at 10:43 AM, Gerry Boland
<email address hidden> wrote:
> You have been requested to review the proposed merge of lp:~dyams/unity-2d/remove-glow into lp:unity-2d.
>
> For more details, see:
> https://code.launchpad.net/~dyams/unity-2d/remove-glow/+merge/93807
>
> [Shell] remove glow
>
> --
> https://code.launchpad.net/~dyams/unity-2d/remove-glow/+merge/93807
> Your team Ayatana Discussion is requested to review the proposed merge of lp:~dyams/unity-2d/remove-glow into lp:unity-2d.
>
> === modified file 'shell/common/artwork/search_background.png'
> Binary files shell/common/artwork/search_background.png 2012-02-01 23:52:38 +0000 and shell/common/artwork/search_background.png 2012-02-20 11:47:59 +0000 differ
> === modified file 'shell/common/artwork/search_icon.png'
> Binary files shell/common/artwork/search_icon.png 2012-02-01 23:52:38 +0000 and shell/common/artwork/search_icon.png 2012-02-20 11:47:59 +0000 differ
> === modified file 'shell/dash/LensButton.qml'
> --- shell/dash/LensButton.qml 2011-12-08 19:16:20 +0000
> +++ shell/dash/LensButton.qml 2012-02-20 11:47:59 +0000
> @@ -31,14 +31,6 @@
>
> id: lensButton
>
> - effect: DropShadow {
> - blurRadius: 8
> - color: "white"
> - offset.x: 0
> - offset.y: 0
> - enabled: ( lensButton.state == "selected" || active )
> - }
> -
> Rectangle {
> anchors.fill: parent
> anchors.topMargin: 7
>
> === modified file 'shell/launcher/artwork/launcher_arrow_ltr.png'
> Binary files shell/launcher/artwork/launcher_arrow_ltr.png 2011-11-11 10:19:14 +0000 and shell/launcher/artwork/launcher_arrow_ltr.png 2012-02-20 11:47:59 +0000 differ
> === modified file 'shell/launcher/artwork/launcher_arrow_outline_ltr.png'
> Binary files shell/launcher/artwork/launcher_arrow_outline_ltr.png 2012-01-23 13:23:59 +0000 and shell/launcher/artwork/launcher_arrow_outline_ltr.png 2012-02-20 11:47:59 +0000 differ
> === modified file 'shell/launcher/artwork/launcher_arrow_rtl.png'
> Binary files shell/launcher/artwork/launcher_arrow_rtl.png 2011-11-11 10:19:14 +0000 and shell/launcher/artwork/launcher_arrow_rtl.png 2012-02-20 11:47:59 +0000 differ
> === modified file 'shell/launcher/artwork/launcher_pip_ltr.png'
> Binary files shell/launcher/artwork/launcher_pip_ltr.png 2011-11-11 10:19:14 +0000 and shell/launcher/artwork/launcher_pip_ltr.png 2012-02-20 11:47:59 +0000 differ
>
--
Paulo José da Silva e Silva
Professor Associado, Dep. de Ciência da Computação
(Associate Professor, Computer Science Dept.)
Universidade de São Paulo - Brazil
Sorry,
But I am not sure why I got the message below. I don't have enough
expertise to review a patch to unity-2d (I don't know the codebase).
best,
Paulo
On Tue, Feb 21, 2012 at 10:43 AM, Gerry Boland /code.launchpad .net/~dyams/ unity-2d/ remove- glow/+merge/ 93807 /code.launchpad .net/~dyams/ unity-2d/ remove- glow/+merge/ 93807 common/ artwork/ search_ background. png' artwork/ search_ background. png 2012-02-01 23:52:38 +0000 and shell/common/ artwork/ search_ background. png 2012-02-20 11:47:59 +0000 differ common/ artwork/ search_ icon.png' artwork/ search_ icon.png 2012-02-01 23:52:38 +0000 and shell/common/ artwork/ search_ icon.png 2012-02-20 11:47:59 +0000 differ dash/LensButton .qml' LensButton. qml 2011-12-08 19:16:20 +0000 LensButton. qml 2012-02-20 11:47:59 +0000 launcher/ artwork/ launcher_ arrow_ltr. png' artwork/ launcher_ arrow_ltr. png 2011-11-11 10:19:14 +0000 and shell/launcher/ artwork/ launcher_ arrow_ltr. png 2012-02-20 11:47:59 +0000 differ launcher/ artwork/ launcher_ arrow_outline_ ltr.png' artwork/ launcher_ arrow_outline_ ltr.png 2012-01-23 13:23:59 +0000 and shell/launcher/ artwork/ launcher_ arrow_outline_ ltr.png 2012-02-20 11:47:59 +0000 differ launcher/ artwork/ launcher_ arrow_rtl. png' artwork/ launcher_ arrow_rtl. png 2011-11-11 10:19:14 +0000 and shell/launcher/ artwork/ launcher_ arrow_rtl. png 2012-02-20 11:47:59 +0000 differ launcher/ artwork/ launcher_ pip_ltr. png' artwork/ launcher_ pip_ltr. png 2011-11-11 10:19:14 +0000 and shell/launcher/ artwork/ launcher_ pip_ltr. png 2012-02-20 11:47:59 +0000 differ
<email address hidden> wrote:
> You have been requested to review the proposed merge of lp:~dyams/unity-2d/remove-glow into lp:unity-2d.
>
> For more details, see:
> https:/
>
> [Shell] remove glow
>
> --
> https:/
> Your team Ayatana Discussion is requested to review the proposed merge of lp:~dyams/unity-2d/remove-glow into lp:unity-2d.
>
> === modified file 'shell/
> Binary files shell/common/
> === modified file 'shell/
> Binary files shell/common/
> === modified file 'shell/
> --- shell/dash/
> +++ shell/dash/
> @@ -31,14 +31,6 @@
>
> id: lensButton
>
> - effect: DropShadow {
> - blurRadius: 8
> - color: "white"
> - offset.x: 0
> - offset.y: 0
> - enabled: ( lensButton.state == "selected" || active )
> - }
> -
> Rectangle {
> anchors.fill: parent
> anchors.topMargin: 7
>
> === modified file 'shell/
> Binary files shell/launcher/
> === modified file 'shell/
> Binary files shell/launcher/
> === modified file 'shell/
> Binary files shell/launcher/
> === modified file 'shell/
> Binary files shell/launcher/
>
--
Paulo José da Silva e Silva
Professor Associado, Dep. de Ciência da Computação
(Associate Professor, Computer Science Dept.)
Universidade de São Paulo - Brazil
e-mail: <email address hidden> Web: http:// www.ime. usp.br/ ~pjssilva