Code review comment for lp:~dyams/unity-2d/launcher-update-visible-menu

Revision history for this message
Albert Astals Cid (aacid) wrote :

> > Things that need fixing:
> > * You should disconnect the triggered signal, otherwise that menu entry is
> > not connected to any slot any more.
>
> As I can see I have disconnected the 'onKeepTriggered' in the same update
> method. Did you mean any other signal/slot?

What I am saying is that you should not disconnect the signal. If you do when you click the "Remove from launcher" action it will do nothing.

review: Needs Fixing

« Back to merge proposal