Code review comment for lp:~dyams/unity-2d/launcher-update-visible-menu

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

> Something else i forgot, I am not sure why you are doing
> if (action->parent() == m_menu) {
> could you clarify? Is it in case it is not the action we created? If you are
> removing it from the menu you might as well delete it too. Even better, if you
> change to checking the objectname as i suggested, you'll be "almost really
> sure" it is the action we created, so there is no need to do this check.
Yes, that was not necessary, but am sure i'm deleting it as soon as removing it from the menu.
action->deleteLater is there. no? Or do you mean something else?
Yes, am using object names now.

« Back to merge proposal