Code review comment for lp:~dx-unity/unity/unity.fix_702431

Revision history for this message
Alejandro PiƱeiro (apinheiro) wrote :

I have just tested old revisions of unity (revno 1029 and revno 1050) and the "Launcher is not announced" regression is also there. Although it is also true that I'm using the last compiz (as was required for this proposal), and the last nux, what it is true is that this specific change doesn't seems to be the one causing the regression (as the one causing it seems to be already merged).

So, as the code seems ok, and the regression is not caused directly by this change, I think that it would be ok to approve it.

review: Approve

« Back to merge proposal