Ubuntu
unzip package

Code review comment for ~dviererbe/ubuntu/+source/unzip:fix-missing-documentation-and-add-autopkgtest

  1. Git
  2. lp:~dviererbe/ubuntu/+source/unzip
  3. fix-missing-documentation-and-add-autopkgtest
  4. Merge into ubuntu/devel
Revision history for this message
Dominik Viererbe (dviererbe) wrote (last edit ):

> I think this is worth a deeper revisit to patch it once and patch it right - unless you disagree.
I think so too, but I would like to get these changes uploaded. I created a new bug ticked to address the mentioned concerns.
See LP: #2054625

> debian/tests/control also has trailing whitespace
>
> debian/tests/smoke-tests has shellcheck reports
> SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
>
> debian/tests/SmokeTests.py also has a lot of whitespace damage
> Since this is new how about throwing your favorite python linter and styler on it until it is silent?
This is now fixed.

> Finally you either have written a lot of tests (thanks) or [...]
I wrote the test suite myself.

« Back to merge proposal