Code review comment for ~dviererbe/ubuntu/+source/dash:merge-lp2026730-mantic

Revision history for this message
Dominik Viererbe (dviererbe) wrote :

Hi Lukas, thanks for the feedback!

- I have edited the commits to include the corresponding bug report in the changelog and removed the removal of empty newlines in the changelog (this is weird to me, as I did not remove the newlines myself in the first place; has to be some git-ubuntu magic ¯\_(ツ)_/¯).
- I triggered autopkgtests in my PPA. The first comment of mine [1] links to the logs of the autopkgtests, which all have passed.

[1] https://code.launchpad.net/~dviererbe/ubuntu/+source/dash/+git/dash/+merge/446503/comments/1189914

« Back to merge proposal