Hi Dominik, overall the change (and git history) looks good to me, just some tiny remarks:
* Please close the corresponding bug report from your d/changelog file (in your "reconstruct-changelog" commit), e.g.
"Merge with Debian unstable (LP: #2026730). Remaining changes:"
* While on it, please drop the removal of empty newlines from d/changelog (in your "merge-changelogs" commit). I know it looks cleaner this way, but it's unnecessary delta to track in Ubuntu and we should just stick to whatever Debian did, as it doesn't affect the functionality.
* Did you run any autopkgtest on this locally or on your PPA? Or did any other testing around the diversion change?
Hi Dominik, overall the change (and git history) looks good to me, just some tiny remarks:
* Please close the corresponding bug report from your d/changelog file (in your "reconstruct- changelog" commit), e.g.
"Merge with Debian unstable (LP: #2026730). Remaining changes:"
* While on it, please drop the removal of empty newlines from d/changelog (in your "merge-changelogs" commit). I know it looks cleaner this way, but it's unnecessary delta to track in Ubuntu and we should just stick to whatever Debian did, as it doesn't affect the functionality.
* Did you run any autopkgtest on this locally or on your PPA? Or did any other testing around the diversion change?