Merge lp:~dveeden/mysql-server/mysql-5.5-bug61038 into lp:~mysql/mysql-server/mysql-trunk

Proposed by Daniël van Eeden
Status: Superseded
Proposed branch: lp:~dveeden/mysql-server/mysql-5.5-bug61038
Merge into: lp:~mysql/mysql-server/mysql-trunk
Diff against target: 82 lines (+29/-11)
2 files modified
client/mysqladmin.cc (+23/-6)
support-files/mysql-log-rotate.sh (+6/-5)
To merge this branch: bzr merge lp:~dveeden/mysql-server/mysql-5.5-bug61038
Reviewer Review Type Date Requested Status
Oracle/MySQL Engineering Pending
Review via email: mp+59763@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

3454. By Daniël van Eeden

Change variables from log-err to error-log. Suggest the use of the
mysqld section instead of safe_mysqld. Also change safe_mysqld to
mysqld_safe.

3453. By Daniël van Eeden

Merge from mysql-5.5

3452. By Daniël van Eeden

Fix typo

3451. By Daniël van Eeden

Merge from mysql-5.5 branch

3450. By Daniël van Eeden

Update help info

3449. By Daniël van Eeden

Adjust version, this is supported from 5.5.3 according to
the docs, not since 5.5.0.

3448. By Daniël van Eeden

Add specific log flushing to mysqladmin (Bug #60878)

3447. By Serge Kozlov

autocommit 5.1 -> 5.5

3446. By Sergey Glukhov

automerge

3445. By Sergey Glukhov

5.1 -> 5.5 merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'client/mysqladmin.cc'
--- client/mysqladmin.cc 2011-02-11 14:38:34 +0000
+++ client/mysqladmin.cc 2011-05-03 12:09:59 +0000
@@ -869,11 +869,28 @@
869 }869 }
870 case ADMIN_FLUSH_LOGS:870 case ADMIN_FLUSH_LOGS:
871 {871 {
872 if (mysql_refresh(mysql,REFRESH_LOG))872 if ((argc == 2) && ((strcasecmp(argv[1],"binary") == 0)
873 {873 || (strcasecmp(argv[1],"engine") == 0)
874 my_printf_error(0, "refresh failed; error: '%s'", error_flags,874 || (strcasecmp(argv[1],"error") == 0)
875 mysql_error(mysql));875 || (strcasecmp(argv[1],"general") == 0)
876 return -1;876 || (strcasecmp(argv[1],"relay") == 0)
877 || (strcasecmp(argv[1],"slow") == 0))) {
878 char buff[42];
879 sprintf(buff,"FLUSH /*!50503 %s */ LOGS",argv[1]);
880 if (mysql_query(mysql,buff))
881 {
882 my_printf_error(0, "refresh failed; error: '%s'", error_flags,
883 mysql_error(mysql));
884 return -1;
885 }
886 argc--; argv++;
887 } else {
888 if (mysql_refresh(mysql,REFRESH_LOG))
889 {
890 my_printf_error(0, "refresh failed; error: '%s'", error_flags,
891 mysql_error(mysql));
892 return -1;
893 }
877 }894 }
878 break;895 break;
879 }896 }
@@ -1104,7 +1121,7 @@
1104 drop databasename Delete a database and all its tables\n\1121 drop databasename Delete a database and all its tables\n\
1105 extended-status Gives an extended status message from the server\n\1122 extended-status Gives an extended status message from the server\n\
1106 flush-hosts Flush all cached hosts\n\1123 flush-hosts Flush all cached hosts\n\
1107 flush-logs Flush all logs\n\1124 flush-logs logtype Flush all logs or logs of just one logtype\n\
1108 flush-status Clear status variables\n\1125 flush-status Clear status variables\n\
1109 flush-tables Flush all tables\n\1126 flush-tables Flush all tables\n\
1110 flush-threads Flush the thread cache\n\1127 flush-threads Flush the thread cache\n\
11111128
=== modified file 'support-files/mysql-log-rotate.sh'
--- support-files/mysql-log-rotate.sh 2005-01-18 16:35:32 +0000
+++ support-files/mysql-log-rotate.sh 2011-05-03 12:09:59 +0000
@@ -1,9 +1,9 @@
1# This logname can be set in /etc/my.cnf1# This logname can be set in /etc/my.cnf
2# by setting the variable "err-log"2# by setting the variable "err-log"
3# in the [safe_mysqld] section as follows:3# in the [mysqld] or [mysqld_safe] section as follows:
4#4#
5# [safe_mysqld]5# [mysqld]
6# err-log=@localstatedir@/mysqld.log6# log-error=@localstatedir@/mysqld.log
7#7#
8# If the root user has a password you have to create a8# If the root user has a password you have to create a
9# /root/.my.cnf configuration file with the following9# /root/.my.cnf configuration file with the following
@@ -13,7 +13,8 @@
13# password = <secret> 13# password = <secret>
14# user= root14# user= root
15#15#
16# where "<secret>" is the password. 16# where "<secret>" is the password. mysqladmin will also
17# read the [client] section.
17#18#
18# ATTENTION: This /root/.my.cnf should be readable ONLY19# ATTENTION: This /root/.my.cnf should be readable ONLY
19# for root !20# for root !
@@ -22,7 +23,7 @@
22 # create 600 mysql mysql23 # create 600 mysql mysql
23 notifempty24 notifempty
24 daily25 daily
25 rotate 326 rotate 5
26 missingok27 missingok
27 compress28 compress
28 postrotate29 postrotate

Subscribers

People subscribed via source and target branches

to status/vote changes: