Code review comment for lp:~dude-from-by/openlp/my-ios-remote
Revision history for this message
| andrei (dude-from-by) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> Hi Andrei. Sorry for delay.
> Follows some things that can be fixed:
>
> - The search is not working on iOS 8;
> - Keep te search button aways enabled. Search with empty textfield will do a
> full search.
- fixed for ios8
- made search button enabled.
I don't like an option to keep it enabled - it is counter-intuitive. I've looked through many apps, most Apple apps I use - none of them uses such solution. Some of them display full list initially and non of them enables search button if there is nothing in the input field. As for now I will rollback to your solution, but in the future we may come up with one that is easier to understand for user.