Code review comment for lp:~dstroppa/juju-core/joyent-provider-storage

The attempt to merge lp:~dstroppa/juju-core/joyent-provider-storage into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core 0.017s
ok launchpad.net/juju-core/agent 1.822s
ok launchpad.net/juju-core/agent/tools 0.422s
ok launchpad.net/juju-core/bzr 13.422s
ok launchpad.net/juju-core/cert 3.682s
ok launchpad.net/juju-core/charm 0.843s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]
ok launchpad.net/juju-core/cloudinit 0.055s
ok launchpad.net/juju-core/cloudinit/sshinit 1.303s
ok launchpad.net/juju-core/cmd 0.245s
ok launchpad.net/juju-core/cmd/charm-admin 0.940s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 317.348s
ok launchpad.net/juju-core/cmd/jujud 83.188s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 15.117s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/constraints 0.056s
ok launchpad.net/juju-core/container 0.148s
ok launchpad.net/juju-core/container/factory 0.070s
ok launchpad.net/juju-core/container/kvm 0.403s
ok launchpad.net/juju-core/container/kvm/mock 0.093s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 0.531s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.339s
ok launchpad.net/juju-core/environs 3.208s
ok launchpad.net/juju-core/environs/bootstrap 5.410s
ok launchpad.net/juju-core/environs/cloudinit 0.652s
ok launchpad.net/juju-core/environs/config 5.612s
ok launchpad.net/juju-core/environs/configstore 0.189s
ok launchpad.net/juju-core/environs/filestorage 0.032s
ok launchpad.net/juju-core/environs/httpstorage 1.047s
ok launchpad.net/juju-core/environs/imagemetadata 1.067s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.982s
ok launchpad.net/juju-core/environs/jujutest 0.280s
ok launchpad.net/juju-core/environs/manual 14.988s
ok launchpad.net/juju-core/environs/simplestreams 2.050s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 3.161s
ok launchpad.net/juju-core/environs/storage 1.238s
ok launchpad.net/juju-core/environs/sync 43.628s
ok launchpad.net/juju-core/environs/testing 0.784s
ok launchpad.net/juju-core/environs/tools 7.430s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.016s
ok launchpad.net/juju-core/instance 0.027s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 30.506s
ok launchpad.net/juju-core/juju/osenv 0.033s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.061s
ok launchpad.net/juju-core/log/syslog 0.038s
? launchpad.net/juju-core/log/syslog/testing [no test files]
ok launchpad.net/juju-core/names 0.031s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 8.519s
ok launchpad.net/juju-core/provider/common 8.487s
ok launchpad.net/juju-core/provider/dummy 31.117s
ok launchpad.net/juju-core/provider/ec2 21.561s
ok launchpad.net/juju-core/provider/joyent 14.227s
ok launchpad.net/juju-core/provider/local 6.909s
ok launchpad.net/juju-core/provider/maas 22.687s
ok launchpad.net/juju-core/provider/manual 1.800s
ok launchpad.net/juju-core/provider/openstack 41.866s
ok launchpad.net/juju-core/replicaset 48.564s
ok launchpad.net/juju-core/rpc 0.100s
ok launchpad.net/juju-core/rpc/jsoncodec 0.049s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.045s
ok launchpad.net/juju-core/state 126.720s
ok launchpad.net/juju-core/state/api 2.176s
ok launchpad.net/juju-core/state/api/agent 2.454s
? launchpad.net/juju-core/state/api/base [no test files]
ok launchpad.net/juju-core/state/api/charmrevisionupdater 1.456s
? launchpad.net/juju-core/state/api/common [no test files]
? launchpad.net/juju-core/state/api/common/testing [no test files]
ok launchpad.net/juju-core/state/api/deployer 8.146s
ok launchpad.net/juju-core/state/api/environment 2.139s
ok launchpad.net/juju-core/state/api/firewaller 15.056s
ok launchpad.net/juju-core/state/api/keymanager 6.301s
ok launchpad.net/juju-core/state/api/keyupdater 3.350s
ok launchpad.net/juju-core/state/api/logger 3.490s
ok launchpad.net/juju-core/state/api/machiner 6.215s
ok launchpad.net/juju-core/state/api/params 0.054s
ok launchpad.net/juju-core/state/api/provisioner 12.894s
ok launchpad.net/juju-core/state/api/rsyslog 2.324s
ok launchpad.net/juju-core/state/api/uniter 40.303s
ok launchpad.net/juju-core/state/api/upgrader 14.937s
ok launchpad.net/juju-core/state/api/watcher 4.061s
ok launchpad.net/juju-core/state/apiserver 13.915s
ok launchpad.net/juju-core/state/apiserver/agent 3.449s
ok launchpad.net/juju-core/state/apiserver/charmrevisionupdater 2.880s
? launchpad.net/juju-core/state/apiserver/charmrevisionupdater/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/client 55.130s
ok launchpad.net/juju-core/state/apiserver/common 3.041s
? launchpad.net/juju-core/state/apiserver/common/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/deployer 6.014s
ok launchpad.net/juju-core/state/apiserver/environment 1.898s
ok launchpad.net/juju-core/state/apiserver/firewaller 7.496s
ok launchpad.net/juju-core/state/apiserver/keymanager 6.357s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 3.394s
ok launchpad.net/juju-core/state/apiserver/logger 3.763s
ok launchpad.net/juju-core/state/apiserver/machine 3.171s
ok launchpad.net/juju-core/state/apiserver/provisioner 13.968s
ok launchpad.net/juju-core/state/apiserver/rsyslog 3.304s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 26.052s
ok launchpad.net/juju-core/state/apiserver/upgrader 16.597s
ok launchpad.net/juju-core/state/multiwatcher 0.797s
ok launchpad.net/juju-core/state/presence 7.087s
ok launchpad.net/juju-core/state/statecmd 2.447s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 7.149s
ok launchpad.net/juju-core/store 27.965s
ok launchpad.net/juju-core/testing 1.528s
ok launchpad.net/juju-core/testing/checkers 0.025s
ok launchpad.net/juju-core/testing/testbase 0.020s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.208s
ok launchpad.net/juju-core/tools 0.038s
ok launchpad.net/juju-core/upgrades 6.433s
ok launchpad.net/juju-core/upstart 0.161s
ok launchpad.net/juju-core/utils 2.700s
ok launchpad.net/juju-core/utils/exec 0.059s
ok launchpad.net/juju-core/utils/fslock 1.125s
ok launchpad.net/juju-core/utils/parallel 0.967s
ok launchpad.net/juju-core/utils/set 0.019s
ok launchpad.net/juju-core/utils/ssh 24.023s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 1.018s
ok launchpad.net/juju-core/utils/voyeur 0.018s
ok launchpad.net/juju-core/version 0.292s
ok launchpad.net/juju-core/worker 7.032s
ok launchpad.net/juju-core/worker/authenticationworker 4.663s
ok launchpad.net/juju-core/worker/charmrevisionworker 2.759s
ok launchpad.net/juju-core/worker/cleaner 1.364s
ok launchpad.net/juju-core/worker/deployer 4.507s
ok launchpad.net/juju-core/worker/firewaller 16.295s
ok launchpad.net/juju-core/worker/instancepoller 2.571s
ok launchpad.net/juju-core/worker/localstorage 0.068s
ok launchpad.net/juju-core/worker/logger 1.721s
ok launchpad.net/juju-core/worker/machineenvironmentworker 8.212s
ok launchpad.net/juju-core/worker/machiner 3.344s
ok launchpad.net/juju-core/worker/minunitsworker 1.392s
ok launchpad.net/juju-core/worker/peergrouper 1.231s
ok launchpad.net/juju-core/worker/provisioner 47.396s
ok launchpad.net/juju-core/worker/resumer 1.678s
ok launchpad.net/juju-core/worker/rsyslog 5.006s
ok launchpad.net/juju-core/worker/terminationworker 0.082s
ok launchpad.net/juju-core/worker/uniter 225.755s
ok launchpad.net/juju-core/worker/uniter/charm 3.535s
ok launchpad.net/juju-core/worker/uniter/debug 0.097s
ok launchpad.net/juju-core/worker/uniter/hook 0.015s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.514s
ok launchpad.net/juju-core/worker/uniter/relation 1.493s
*** Test killed: ran too long (10m0s).
FAIL launchpad.net/juju-core/worker/upgrader 600.014s

warning: building out-of-date packages:
 launchpad.net/lpad
 launchpad.net/gojoyent/jpc
 launchpad.net/gojoyent/auth
 launchpad.net/gojoyent
 launchpad.net/gojoyent/errors
 launchpad.net/gojoyent/http
 launchpad.net/gojoyent/client
 launchpad.net/gojoyent/manta
 launchpad.net/gojoyent/localservices/hook
 launchpad.net/gojoyent/localservices
 launchpad.net/gojoyent/localservices/manta
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.