Code review comment for lp:~dstroppa/juju-core/joyent-provider-storage

Revision history for this message
Daniele Stroppa (dstroppa) wrote :

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/config_test.go
File provider/joyent/config_test.go (right):

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/config_test.go#newcode26
provider/joyent/config_test.go:26: "sdc-key-id":
"12:c3:a7:cb:a2:29:e2:90:88:3f:04:53:3b:4e:75:40",
On 2014/01/09 17:50:34, gz wrote:
> Not changed here, but duplicated later, so mentioning. These fake
values should
> be faker, rather than being for name and a real-looking key id. Better
to spot
> in test assertions and such like if it's testuser and 00:11:22:... or
similar
> obvious made up values.

Changed to obvious made up values.

https://codereview.appspot.com/49050044/

« Back to merge proposal