Code review comment for lp:~dstroppa/juju-core/joyent-provider-storage

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go
File provider/joyent/storage.go (right):

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode83
provider/joyent/storage.go:83: // deleteContainer deletes the named
comtainer from the storage account.
On 2014/01/09 17:50:34, gz wrote:
> Typo, 'coNtainer'.

Done.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode107
provider/joyent/storage.go:107: //return something that a random wget
can retrieve the object at, without any credentials
On 2014/01/09 17:50:34, gz wrote:
> This may as well be an actual function doc comment.

Done.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode109
provider/joyent/storage.go:109: return s.manta.SignURL(path,
time.Now().Add(time.Minute*5))
On 2014/01/09 17:50:34, gz wrote:
> I think the EC2 provider uses a mcuh longer duration, what a sensible
value is
> I'm less sure.

5 minutes is the value used in the Node.js SDK (used as reference). EC2,
Azure and OpenStack providers use 10 years. Changed to 10 years to be
consistent.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode125
provider/joyent/storage.go:125: //obj := r.Read()
On 2014/01/09 17:50:34, gz wrote:
> Remove.

Done.

https://codereview.appspot.com/49050044/