Merge lp:~dstansby-deactivatedaccount/language-selector/bugfix-lp-598619 into lp:language-selector

Proposed by David Stansby
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp:~dstansby-deactivatedaccount/language-selector/bugfix-lp-598619
Merge into: lp:language-selector
Diff against target: 443 lines (+104/-104)
3 files modified
LanguageSelector/CheckLanguageSupport.py (+27/-27)
LanguageSelector/LangCache.py (+39/-39)
LanguageSelector/LanguageSelector.py (+38/-38)
To merge this branch: bzr merge lp:~dstansby-deactivatedaccount/language-selector/bugfix-lp-598619
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+28585@code.launchpad.net

Description of the change

Fixed some deprecated variables

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Similar changes have landed in 0.6.1 so closing this merge request

Unmerged revisions

371. By David Stansby

Fixed deprecated variables

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'LanguageSelector/CheckLanguageSupport.py'
--- LanguageSelector/CheckLanguageSupport.py 2010-05-26 14:40:53 +0000
+++ LanguageSelector/CheckLanguageSupport.py 2010-06-27 09:34:31 +0000
@@ -33,7 +33,7 @@
33 for x in scanlist:33 for x in scanlist:
34 pkg = '%s-%s' % (x, pkgcode)34 pkg = '%s-%s' % (x, pkgcode)
35 if pkg in self._cache:35 if pkg in self._cache:
36 if not self._cache[pkg].isInstalled and \36 if not self._cache[pkg].is_installed and \
37 not self._cache[pkg].markedInstall:37 not self._cache[pkg].markedInstall:
38 self.missing.add(pkg)38 self.missing.add(pkg)
39 else:39 else:
@@ -45,23 +45,23 @@
45 if pkg in packages and \45 if pkg in packages and \
46 pkg in self._cache and \46 pkg in self._cache and \
47 translation in self._cache:47 translation in self._cache:
48 if ((not self._cache[translation].isInstalled and \48 if ((not self._cache[translation].is_installed and \
49 not self._cache[translation].markedInstall and \49 not self._cache[translation].markedInstall and \
50 not self._cache[translation].markedUpgrade) or \50 not self._cache[translation].marked_marked_upgrade) or \
51 self._cache[translation].markedDelete):51 self._cache[translation].marked_delete):
52 self.missing.add(translation)52 self.missing.add(translation)
53 else:53 else:
54 self.installed.add(translation)54 self.installed.add(translation)
55 else:55 else:
56 if pkg in self._cache and \56 if pkg in self._cache and \
57 (self._cache[pkg].isInstalled or \57 (self._cache[pkg].is_installed or \
58 self._cache[pkg].markedInstall or \58 self._cache[pkg].markedInstall or \
59 self._cache[pkg].markedUpgrade) and \59 self._cache[pkg].marked_marked_upgrade) and \
60 translation in self._cache:60 translation in self._cache:
61 if ((not self._cache[translation].isInstalled and \61 if ((not self._cache[translation].is_installed and \
62 not self._cache[translation].markedInstall and \62 not self._cache[translation].markedInstall and \
63 not self._cache[translation].markedUpgrade) or \63 not self._cache[translation].marked_marked_upgrade) or \
64 self._cache[translation].markedDelete):64 self._cache[translation].marked_delete):
65 self.missing.add(translation)65 self.missing.add(translation)
66 else:66 else:
67 self.installed.add(translation)67 self.installed.add(translation)
@@ -69,7 +69,7 @@
69 if pkgcode in self.pkg_writing and \69 if pkgcode in self.pkg_writing and \
70 (pkgcode == self.system_pkgcode or \70 (pkgcode == self.system_pkgcode or \
71 ('language-support-writing-%s' % pkgcode in self._cache and \71 ('language-support-writing-%s' % pkgcode in self._cache and \
72 self._cache['language-support-writing-%s' % pkgcode].isInstalled) or \72 self._cache['language-support-writing-%s' % pkgcode].is_installed) or \
73 ('language-support-writing-%s' % pkgcode in self._cache and \73 ('language-support-writing-%s' % pkgcode in self._cache and \
74 self._cache['language-support-writing-%s' % pkgcode].markInstall) or \74 self._cache['language-support-writing-%s' % pkgcode].markInstall) or \
75 ('language-support-writing-%s' % pkgcode in self._cache and \75 ('language-support-writing-%s' % pkgcode in self._cache and \
@@ -82,24 +82,24 @@
82 if p in packages and \82 if p in packages and \
83 p in self._cache and \83 p in self._cache and \
84 pull_pkg in self._cache:84 pull_pkg in self._cache:
85 if ((not self._cache[pull_pkg].isInstalled and \85 if ((not self._cache[pull_pkg].is_installed and \
86 not self._cache[pull_pkg].markedInstall and \86 not self._cache[pull_pkg].markedInstall and \
87 not self._cache[pull_pkg].markedUpgrade) or \87 not self._cache[pull_pkg].marked_marked_upgrade) or \
88 self._cache[pull_pkg].markedDelete):88 self._cache[pull_pkg].marked_delete):
89 self.missing.add(pull_pkg)89 self.missing.add(pull_pkg)
90 else:90 else:
91 self.installed.add(pull_pkg)91 self.installed.add(pull_pkg)
92 break92 break
93 else:93 else:
94 if p in self._cache and \94 if p in self._cache and \
95 (self._cache[p].isInstalled or \95 (self._cache[p].is_installed or \
96 self._cache[p].markedInstall or \96 self._cache[p].markedInstall or \
97 self._cache[p].markedUpgrade) and \97 self._cache[p].marked_marked_upgrade) and \
98 pull_pkg in self._cache:98 pull_pkg in self._cache:
99 if ((not self._cache[pull_pkg].isInstalled and \99 if ((not self._cache[pull_pkg].is_installed and \
100 not self._cache[pull_pkg].markedInstall and \100 not self._cache[pull_pkg].markedInstall and \
101 not self._cache[pull_pkg].markedUpgrade) or \101 not self._cache[pull_pkg].marked_marked_upgrade) or \
102 self._cache[pull_pkg].markedDelete):102 self._cache[pull_pkg].marked_delete):
103 self.missing.add(pull_pkg)103 self.missing.add(pull_pkg)
104 else:104 else:
105 self.installed.add(pull_pkg)105 self.installed.add(pull_pkg)
@@ -109,23 +109,23 @@
109 if pkg in packages and \109 if pkg in packages and \
110 pkg in self._cache and \110 pkg in self._cache and \
111 pull_pkg in self._cache:111 pull_pkg in self._cache:
112 if ((not self._cache[pull_pkg].isInstalled and \112 if ((not self._cache[pull_pkg].is_installed and \
113 not self._cache[pull_pkg].markedInstall and \113 not self._cache[pull_pkg].markedInstall and \
114 not self._cache[pull_pkg].markedUpgrade) or \114 not self._cache[pull_pkg].marked_marked_upgrade) or \
115 self._cache[pull_pkg].markedDelete):115 self._cache[pull_pkg].marked_delete):
116 self.missing.add(pull_pkg)116 self.missing.add(pull_pkg)
117 else:117 else:
118 self.installed.add(pull_pkg)118 self.installed.add(pull_pkg)
119 else:119 else:
120 if pkg in self._cache and \120 if pkg in self._cache and \
121 (self._cache[pkg].isInstalled or \121 (self._cache[pkg].is_installed or \
122 self._cache[pkg].markedInstall or \122 self._cache[pkg].markedInstall or \
123 self._cache[pkg].markedUpgrade) and \123 self._cache[pkg].marked_marked_upgrade) and \
124 pull_pkg in self._cache:124 pull_pkg in self._cache:
125 if ((not self._cache[pull_pkg].isInstalled and \125 if ((not self._cache[pull_pkg].is_installed and \
126 not self._cache[pull_pkg].markedInstall and \126 not self._cache[pull_pkg].markedInstall and \
127 not self._cache[pull_pkg].markedUpgrade) or \127 not self._cache[pull_pkg].marked_marked_upgrade) or \
128 self._cache[pull_pkg].markedDelete):128 self._cache[pull_pkg].marked_delete):
129 self.missing.add(pull_pkg)129 self.missing.add(pull_pkg)
130 else:130 else:
131 self.installed.add(pull_pkg)131 self.installed.add(pull_pkg)
@@ -295,7 +295,7 @@
295 not item.startswith('language-pack-gnome') and \295 not item.startswith('language-pack-gnome') and \
296 not item.startswith('language-pack-kde') and \296 not item.startswith('language-pack-kde') and \
297 not item.endswith('-base') and \297 not item.endswith('-base') and \
298 (self._cache[item].isInstalled or \298 (self._cache[item].is_installed or \
299 self._cache[item].markedInstall):299 self._cache[item].markedInstall):
300 pkgcode = item.replace('language-pack-', '')300 pkgcode = item.replace('language-pack-', '')
301 pkgcodes.append(pkgcode)301 pkgcodes.append(pkgcode)
302302
=== modified file 'LanguageSelector/LangCache.py'
--- LanguageSelector/LangCache.py 2010-05-28 10:42:08 +0000
+++ LanguageSelector/LangCache.py 2010-06-27 09:34:31 +0000
@@ -39,7 +39,7 @@
39 pkgname = langpkg_status.pkgname_template % languageCode39 pkgname = langpkg_status.pkgname_template % languageCode
40 langpkg_status.available = pkgname in cache40 langpkg_status.available = pkgname in cache
41 if langpkg_status.available:41 if langpkg_status.available:
42 langpkg_status.installed = cache[pkgname].isInstalled42 langpkg_status.installed = cache[pkgname].is_installed
43 43
44 @property44 @property
45 def inconsistent(self):45 def inconsistent(self):
@@ -81,7 +81,7 @@
8181
82 def __init__(self, localeinfo, progress):82 def __init__(self, localeinfo, progress):
83 apt.Cache.__init__(self, progress)83 apt.Cache.__init__(self, progress)
84 if self._depcache.BrokenCount > 0:84 if self._depcache.broken_count > 0:
85 raise ExceptionPkgCacheBroken()85 raise ExceptionPkgCacheBroken()
86 self._localeinfo = localeinfo86 self._localeinfo = localeinfo
87 # keep the lists 87 # keep the lists
@@ -190,15 +190,15 @@
190 @property190 @property
191 def havePackageLists(self):191 def havePackageLists(self):
192 " verify that a network package lists exists "192 " verify that a network package lists exists "
193 for metaindex in self._list.List:193 for metaindex in self._list.list:
194 for indexfile in metaindex.IndexFiles:194 for indexfile in metaindex.index_files:
195 if indexfile.ArchiveURI("").startswith("cdrom:"):195 if indexfile.archive_uri("").startswith("cdrom:"):
196 continue196 continue
197 if indexfile.ArchiveURI("").startswith("http://security.ubuntu.com"):197 if indexfile.archive_uri("").startswith("http://security.ubuntu.com"):
198 continue198 continue
199 if indexfile.Label != "Debian Package Index":199 if indexfile.label != "Debian Package Index":
200 continue200 continue
201 if indexfile.Exists and indexfile.HasPackages:201 if indexfile.exists and indexfile.has_packageiss:
202 return True202 return True
203 return False203 return False
204204
@@ -218,9 +218,9 @@
218 to_inst = []218 to_inst = []
219 to_rm = []219 to_rm = []
220 for pkg in self.getChanges():220 for pkg in self.getChanges():
221 if pkg.markedInstall or pkg.markedUpgrade:221 if pkg.markedInstall or pkg.marked_marked_upgrade:
222 to_inst.append(pkg.name)222 to_inst.append(pkg.name)
223 if pkg.markedDelete:223 if pkg.marked_delete:
224 to_rm.append(pkg.name)224 to_rm.append(pkg.name)
225 return (to_inst,to_rm)225 return (to_inst,to_rm)
226226
@@ -233,7 +233,7 @@
233 "language-pack-%s"%languageCode]233 "language-pack-%s"%languageCode]
234 # see what additional pkgs are needed234 # see what additional pkgs are needed
235 #for (pkg, translation) in self.pkg_translations[languageCode]:235 #for (pkg, translation) in self.pkg_translations[languageCode]:
236 # if pkg in self and self[pkg].isInstalled:236 # if pkg in self and self[pkg].is_installed:
237 # pkg_list.append(translation)237 # pkg_list.append(translation)
238 return pkg_list238 return pkg_list
239 239
@@ -266,22 +266,22 @@
266 if lang_pack_status.available and not lang_pack_status.installed:266 if lang_pack_status.available and not lang_pack_status.installed:
267 for (pkg, translation) in self.pkg_translations[lang_pack_status.languageCode]:267 for (pkg, translation) in self.pkg_translations[lang_pack_status.languageCode]:
268 if pkg in self and \268 if pkg in self and \
269 (self[pkg].isInstalled or \269 (self[pkg].is_installed or \
270 self[pkg].markedInstall or \270 self[pkg].markedInstall or \
271 self[pkg].markedUpgrade) and \271 self[pkg].marked_marked_upgrade) and \
272 translation in self and \272 translation in self and \
273 ((not self[translation].isInstalled and \273 ((not self[translation].is_installed and \
274 not self[translation].markedInstall and \274 not self[translation].markedInstall and \
275 not self[translation].markedUpgrade) or \275 not self[translation].marked_marked_upgrade) or \
276 self[translation].markedDelete):276 self[translation].marked_delete):
277 self[translation].markInstall()277 self[translation].markInstall()
278 #print ("Will pull: %s" % translation)278 #print ("Will pull: %s" % translation)
279 elif lang_pack_status.installed:279 elif lang_pack_status.installed:
280 for (pkg, translation) in self.pkg_translations[lang_pack_status.languageCode]:280 for (pkg, translation) in self.pkg_translations[lang_pack_status.languageCode]:
281 if translation in self and \281 if translation in self and \
282 (self[translation].isInstalled or \282 (self[translation].is_installed or \
283 self[translation].markedInstall or \283 self[translation].markedInstall or \
284 self[translation].markedUpgrade):284 self[translation].marked_marked_upgrade):
285 self[translation].markDelete()285 self[translation].markDelete()
286 #print ("Will remove: %s" % translation)286 #print ("Will remove: %s" % translation)
287287
@@ -296,24 +296,24 @@
296 # multiple dependencies, if one of them is installed, pull the pull_pkg296 # multiple dependencies, if one of them is installed, pull the pull_pkg
297 for p in pkg.split('|'):297 for p in pkg.split('|'):
298 if p in self and \298 if p in self and \
299 (self[p].isInstalled or \299 (self[p].is_installed or \
300 self[p].markedInstall or \300 self[p].markedInstall or \
301 self[p].markedUpgrade) and \301 self[p].marked_marked_upgrade) and \
302 ((not self[pull_pkg].isInstalled and \302 ((not self[pull_pkg].is_installed and \
303 not self[pull_pkg].markedInstall and \303 not self[pull_pkg].markedInstall and \
304 not self[pull_pkg].markedUpgrade) or \304 not self[pull_pkg].marked_marked_upgrade) or \
305 self[pull_pkg].markedDelete):305 self[pull_pkg].marked_delete):
306 self[pull_pkg].markInstall()306 self[pull_pkg].markInstall()
307 #print ("Will pull: %s" % pull_pkg)307 #print ("Will pull: %s" % pull_pkg)
308 else:308 else:
309 if pkg in self and \309 if pkg in self and \
310 (self[pkg].isInstalled or \310 (self[pkg].is_installed or \
311 self[pkg].markedInstall or \311 self[pkg].markedInstall or \
312 self[pkg].markedUpgrade) and \312 self[pkg].marked_marked_upgrade) and \
313 ((not self[pull_pkg].isInstalled and \313 ((not self[pull_pkg].is_installed and \
314 not self[pull_pkg].markedInstall and \314 not self[pull_pkg].markedInstall and \
315 not self[pull_pkg].markedUpgrade) or \315 not self[pull_pkg].marked_marked_upgrade) or \
316 self[pull_pkg].markedDelete):316 self[pull_pkg].marked_delete):
317 self[pull_pkg].markInstall()317 self[pull_pkg].markInstall()
318 #print ("Will pull: %s" % pull_pkg)318 #print ("Will pull: %s" % pull_pkg)
319 elif writing_aid_status.installed and writing_aid_status.doChange:319 elif writing_aid_status.installed and writing_aid_status.doChange:
@@ -328,25 +328,25 @@
328 for l in self.multilang[pull_pkg]:328 for l in self.multilang[pull_pkg]:
329 p = "language-support-writing-%s" % l329 p = "language-support-writing-%s" % l
330 if p in self and \330 if p in self and \
331 (self[p].isInstalled or \331 (self[p].is_installed or \
332 self[p].markedInstall or \332 self[p].markedInstall or \
333 self[p].markedUpgrade) and \333 self[p].marked_marked_upgrade) and \
334 not self[p].markedDelete:334 not self[p].marked_delete:
335 lcount = lcount+1335 lcount = lcount+1
336 if '|' in pkg:336 if '|' in pkg:
337 # multiple dependencies, if at least one of them is installed, keep the pull_pkg337 # multiple dependencies, if at least one of them is installed, keep the pull_pkg
338 # only remove pull_pkg if none of the dependencies are installed anymore338 # only remove pull_pkg if none of the dependencies are installed anymore
339 for p in pkg.split('|'):339 for p in pkg.split('|'):
340 if p in self and \340 if p in self and \
341 (self[p].isInstalled or \341 (self[p].is_installed or \
342 self[p].markedInstall or \342 self[p].markedInstall or \
343 self[p].markedUpgrade) and \343 self[p].marked_marked_upgrade) and \
344 not self[p].markedDelete:344 not self[p].marked_delete:
345 pcount = pcount+1345 pcount = pcount+1
346 if pcount == 0 and lcount == 0 and \346 if pcount == 0 and lcount == 0 and \
347 (self[pull_pkg].isInstalled or \347 (self[pull_pkg].is_installed or \
348 self[pull_pkg].markedInstall or \348 self[pull_pkg].markedInstall or \
349 self[pull_pkg].markedUpgrade):349 self[pull_pkg].marked_marked_upgrade):
350 self[pull_pkg].markDelete()350 self[pull_pkg].markDelete()
351 #print ("Will remove: %s" % pull_pkg)351 #print ("Will remove: %s" % pull_pkg)
352352
353353
=== modified file 'LanguageSelector/LanguageSelector.py'
--- LanguageSelector/LanguageSelector.py 2010-05-27 08:12:43 +0000
+++ LanguageSelector/LanguageSelector.py 2010-06-27 09:34:31 +0000
@@ -52,32 +52,32 @@
52 trans_package = "language-pack-%s" % langInfo.languageCode52 trans_package = "language-pack-%s" % langInfo.languageCode
53 # we have a langpack installed, see if we have all of them53 # we have a langpack installed, see if we have all of them
54 if (trans_package in self._cache and \54 if (trans_package in self._cache and \
55 (self._cache[trans_package].isInstalled or \55 (self._cache[trans_package].is_installed or \
56 self._cache[trans_package].markedInstall or \56 self._cache[trans_package].markedInstall or \
57 self._cache[trans_package].markedUpgrade) and \57 self._cache[trans_package].marked_marked_upgrade) and \
58 not self._cache[trans_package].markedDelete):58 not self._cache[trans_package].marked_delete):
59 #print "IsInstalled: %s " % trans_package59 #print "IsInstalled: %s " % trans_package
60 #print self._cache.pkg_translations[langInfo.languageCode]60 #print self._cache.pkg_translations[langInfo.languageCode]
61 if langInfo.languageCode in self._cache.pkg_translations:61 if langInfo.languageCode in self._cache.pkg_translations:
62 for (pkg, translation) in self._cache.pkg_translations[langInfo.languageCode]:62 for (pkg, translation) in self._cache.pkg_translations[langInfo.languageCode]:
63 if (pkg in self._cache and \63 if (pkg in self._cache and \
64 (self._cache[pkg].isInstalled or \64 (self._cache[pkg].is_installed or \
65 self._cache[pkg].markedInstall or \65 self._cache[pkg].markedInstall or \
66 self._cache[pkg].markedUpgrade) and \66 self._cache[pkg].marked_marked_upgrade) and \
67 not self._cache[pkg].markedDelete and \67 not self._cache[pkg].marked_delete and \
68 translation in self._cache and \68 translation in self._cache and \
69 ((not self._cache[translation].isInstalled and \69 ((not self._cache[translation].is_installed and \
70 not self._cache[translation].markedInstall and \70 not self._cache[translation].markedInstall and \
71 not self._cache[translation].markedUpgrade) or \71 not self._cache[translation].marked_marked_upgrade) or \
72 self._cache[translation].markedDelete) and \72 self._cache[translation].marked_delete) and \
73 not translation in missing):73 not translation in missing):
74 missing.append(translation)74 missing.append(translation)
75 trans_package = "language-support-writing-%s" % langInfo.languageCode75 trans_package = "language-support-writing-%s" % langInfo.languageCode
76 # we have a langsupport-writing installed, see if we have all of them76 # we have a langsupport-writing installed, see if we have all of them
77 if (trans_package in self._cache and 77 if (trans_package in self._cache and
78 (self._cache[trans_package].isInstalled or \78 (self._cache[trans_package].is_installed or \
79 self._cache[trans_package].markedInstall or \79 self._cache[trans_package].markedInstall or \
80 self._cache[trans_package].markedUpgrade)):80 self._cache[trans_package].marked_marked_upgrade)):
81 #print "IsInstalled: %s " % trans_package81 #print "IsInstalled: %s " % trans_package
82 #print self._cache.pkg_writing[langInfo.languageCode]82 #print self._cache.pkg_writing[langInfo.languageCode]
83 if langInfo.languageCode in self._cache.pkg_writing:83 if langInfo.languageCode in self._cache.pkg_writing:
@@ -86,28 +86,28 @@
86 # multiple dependencies, if one of them is installed, pull the pull_pkg86 # multiple dependencies, if one of them is installed, pull the pull_pkg
87 for p in pkg.split('|'):87 for p in pkg.split('|'):
88 if self._cache[p] and \88 if self._cache[p] and \
89 (self._cache[p].isInstalled or \89 (self._cache[p].is_installed or \
90 self._cache[p].markedInstall or \90 self._cache[p].markedInstall or \
91 self._cache[p].markedUpgrade) and \91 self._cache[p].marked_marked_upgrade) and \
92 not self._cache[p].markedDelete and \92 not self._cache[p].marked_delete and \
93 pull_pkg in self._cache and \93 pull_pkg in self._cache and \
94 ((not self._cache[pull_pkg].isInstalled and \94 ((not self._cache[pull_pkg].is_installed and \
95 not self._cache[pull_pkg].markedInstall and \95 not self._cache[pull_pkg].markedInstall and \
96 not self._cache[pull_pkg].markedUpgrade) or \96 not self._cache[pull_pkg].marked_marked_upgrade) or \
97 self._cache[pull_pkg].markedDelete) and \97 self._cache[pull_pkg].marked_delete) and \
98 not pull_pkg in missing:98 not pull_pkg in missing:
99 missing.append(pull_pkg)99 missing.append(pull_pkg)
100 else:100 else:
101 if pkg in self._cache and \101 if pkg in self._cache and \
102 (self._cache[pkg].isInstalled or \102 (self._cache[pkg].is_installed or \
103 self._cache[pkg].markedInstall or \103 self._cache[pkg].markedInstall or \
104 self._cache[pkg].markedUpgrade) and \104 self._cache[pkg].marked_marked_upgrade) and \
105 not self._cache[pkg].markedDelete and \105 not self._cache[pkg].marked_delete and \
106 pull_pkg in self._cache and \106 pull_pkg in self._cache and \
107 ((not self._cache[pull_pkg].isInstalled and \107 ((not self._cache[pull_pkg].is_installed and \
108 not self._cache[pull_pkg].markedInstall and \108 not self._cache[pull_pkg].markedInstall and \
109 not self._cache[pull_pkg].markedUpgrade) or \109 not self._cache[pull_pkg].marked_marked_upgrade) or \
110 self._cache[pull_pkg].markedDelete) and \110 self._cache[pull_pkg].marked_delete) and \
111 not pull_pkg in missing:111 not pull_pkg in missing:
112 missing.append(pull_pkg)112 missing.append(pull_pkg)
113113
@@ -125,16 +125,16 @@
125# pkgcode = self._cache.langpack_locales[default_lang]125# pkgcode = self._cache.langpack_locales[default_lang]
126 trans_package = "language-pack-%s" % pkgcode126 trans_package = "language-pack-%s" % pkgcode
127 if (trans_package in self._cache and 127 if (trans_package in self._cache and
128 not self._cache[trans_package].isInstalled):128 not self._cache[trans_package].is_installed):
129 missing += [trans_package]129 missing += [trans_package]
130 if pkgcode in self._cache.pkg_translations:130 if pkgcode in self._cache.pkg_translations:
131 for (pkg, translation) in self._cache.pkg_translations[pkgcode]:131 for (pkg, translation) in self._cache.pkg_translations[pkgcode]:
132 if (self._cache[pkg].isInstalled and not self._cache[translation].isInstalled):132 if (self._cache[pkg].is_installed and not self._cache[translation].is_installed):
133 missing.append(translation)133 missing.append(translation)
134 support_packages = LanguageSelectorPkgCache._getPkgList(self._cache, pkgcode)134 support_packages = LanguageSelectorPkgCache._getPkgList(self._cache, pkgcode)
135 for support_package in support_packages:135 for support_package in support_packages:
136 if (support_package in self._cache and 136 if (support_package in self._cache and
137 not self._cache[support_package].isInstalled):137 not self._cache[support_package].is_installed):
138 missing.append(support_package)138 missing.append(support_package)
139139
140 if pkgcode in self._cache.pkg_writing:140 if pkgcode in self._cache.pkg_writing:
@@ -143,28 +143,28 @@
143 # multiple dependencies, if one of them is installed, pull the pull_pkg143 # multiple dependencies, if one of them is installed, pull the pull_pkg
144 for p in pkg.split('|'):144 for p in pkg.split('|'):
145 if self._cache[p] and \145 if self._cache[p] and \
146 (self._cache[p].isInstalled or \146 (self._cache[p].is_installed or \
147 self._cache[p].markedInstall or \147 self._cache[p].markedInstall or \
148 self._cache[p].markedUpgrade) and \148 self._cache[p].marked_marked_upgrade) and \
149 not self._cache[p].markedDelete and \149 not self._cache[p].marked_delete and \
150 pull_pkg in self._cache and \150 pull_pkg in self._cache and \
151 ((not self._cache[pull_pkg].isInstalled and \151 ((not self._cache[pull_pkg].is_installed and \
152 not self._cache[pull_pkg].markedInstall and \152 not self._cache[pull_pkg].markedInstall and \
153 not self._cache[pull_pkg].markedUpgrade) or \153 not self._cache[pull_pkg].marked_marked_upgrade) or \
154 self._cache[pull_pkg].markedDelete) and \154 self._cache[pull_pkg].marked_delete) and \
155 not pull_pkg in missing:155 not pull_pkg in missing:
156 missing.append(pull_pkg)156 missing.append(pull_pkg)
157 else:157 else:
158 if pkg in self._cache and \158 if pkg in self._cache and \
159 (self._cache[pkg].isInstalled or \159 (self._cache[pkg].is_installed or \
160 self._cache[pkg].markedInstall or \160 self._cache[pkg].markedInstall or \
161 self._cache[pkg].markedUpgrade) and \161 self._cache[pkg].marked_marked_upgrade) and \
162 not self._cache[pkg].markedDelete and \162 not self._cache[pkg].marked_delete and \
163 pull_pkg in self._cache and \163 pull_pkg in self._cache and \
164 ((not self._cache[pull_pkg].isInstalled and \164 ((not self._cache[pull_pkg].is_installed and \
165 not self._cache[pull_pkg].markedInstall and \165 not self._cache[pull_pkg].markedInstall and \
166 not self._cache[pull_pkg].markedUpgrade) or \166 not self._cache[pull_pkg].marked_marked_upgrade) or \
167 self._cache[pull_pkg].markedDelete) and \167 self._cache[pull_pkg].marked_delete) and \
168 not pull_pkg in missing:168 not pull_pkg in missing:
169 missing.append(pull_pkg)169 missing.append(pull_pkg)
170170

Subscribers

People subscribed via source and target branches

to all changes: