Merge lp:~droetker/ubuntu/saucy/bumblebee/fix-for-1250745 into lp:ubuntu/saucy/bumblebee

Proposed by Christian González
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~droetker/ubuntu/saucy/bumblebee/fix-for-1250745
Merge into: lp:ubuntu/saucy/bumblebee
Diff against target: 78 lines (+21/-5)
4 files modified
debian/bumblebee.postinst (+1/-1)
debian/changelog (+15/-0)
debian/control (+4/-3)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~droetker/ubuntu/saucy/bumblebee/fix-for-1250745
Reviewer Review Type Date Requested Status
Martin Pitt Disapprove
Review via email: mp+194996@code.launchpad.net

Description of the change

removes virtualgl package recommendation

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

I won't merge this as the alternative recommends: is fine. No need to introduce a delta to Debian for this. Thanks!

review: Disapprove

Unmerged revisions

6. By Christian González

remove non-existent 'virtualgl' recommendation (LP: #1250745)

5. By Vincent Cheng

* Use dh-systemd (for systemd-specific additions to maintscripts).
  (Closes: #715270)
* Add bumblebee group as system group (gid in between 100-999) instead
  of a regular group in postinst. (Closes: #718772)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/bumblebee.postinst'
--- debian/bumblebee.postinst 2013-05-03 03:04:38 +0000
+++ debian/bumblebee.postinst 2013-11-13 07:51:09 +0000
@@ -20,7 +20,7 @@
20 # default group and if the group is missing20 # default group and if the group is missing
21 if grep -qx ServerGroup=$BB_GROUP /etc/bumblebee/bumblebee.conf &&21 if grep -qx ServerGroup=$BB_GROUP /etc/bumblebee/bumblebee.conf &&
22 ! getent group $BB_GROUP > /dev/null; then22 ! getent group $BB_GROUP > /dev/null; then
23 groupadd $BB_GROUP23 groupadd --system $BB_GROUP
24 users=$(getent group $USE_GROUPS | cut -d: -f4 | tr , '\n' | sort -u)24 users=$(getent group $USE_GROUPS | cut -d: -f4 | tr , '\n' | sort -u)
25 echo "Adding members from group(s) '$USE_GROUPS' to '$BB_GROUP':"25 echo "Adding members from group(s) '$USE_GROUPS' to '$BB_GROUP':"
26 echo $users26 echo $users
2727
=== modified file 'debian/changelog'
--- debian/changelog 2013-07-11 01:18:07 +0000
+++ debian/changelog 2013-11-13 07:51:09 +0000
@@ -1,3 +1,18 @@
1bumblebee (3.2.1-4ubuntu2) UNRELEASED; urgency=low
2
3 * remove non-existent 'virtualgl' recommendation (LP: #1250745)
4
5 -- Christian A. Reiter <christian@aragorn> Wed, 13 Nov 2013 08:37:49 +0100
6
7bumblebee (3.2.1-4) unstable; urgency=low
8
9 * Use dh-systemd (for systemd-specific additions to maintscripts).
10 (Closes: #715270)
11 * Add bumblebee group as system group (gid in between 100-999) instead
12 of a regular group in postinst. (Closes: #718772)
13
14 -- Vincent Cheng <Vincentc1208@gmail.com> Tue, 20 Aug 2013 02:35:34 -0700
15
1bumblebee (3.2.1-3) unstable; urgency=low16bumblebee (3.2.1-3) unstable; urgency=low
217
3 * Append /usr/lib/primus to CONF_PRIMUS_LD_PATH in d/rules to ease18 * Append /usr/lib/primus to CONF_PRIMUS_LD_PATH in d/rules to ease
419
=== modified file 'debian/control'
--- debian/control 2013-07-11 01:18:07 +0000
+++ debian/control 2013-11-13 07:51:09 +0000
@@ -1,13 +1,14 @@
1Source: bumblebee1Source: bumblebee
2Section: utils2Section: utils
3Priority: extra3Priority: extra
4Maintainer: Debian NVIDIA Maintainers <pkg-nvidia-devel@lists.alioth.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian NVIDIA Maintainers <pkg-nvidia-devel@lists.alioth.debian.org>
5Uploaders: 6Uploaders:
6 Aron Xu <aron@debian.org>, 7 Aron Xu <aron@debian.org>,
7 Vincent Cheng <Vincentc1208@gmail.com>,8 Vincent Cheng <Vincentc1208@gmail.com>,
8 Yunqiang Su <wzssyqa@gmail.com>9 Yunqiang Su <wzssyqa@gmail.com>
9Build-Depends: debhelper (>= 9), libbsd-dev (>= 0.2.0), pkg-config,10Build-Depends: debhelper (>= 9), libbsd-dev (>= 0.2.0), pkg-config,
10 libx11-dev, libglib2.0-dev, help2man11 libx11-dev, libglib2.0-dev, help2man, dh-systemd (>= 1.4)
11Standards-Version: 3.9.412Standards-Version: 3.9.4
12Homepage: https://launchpad.net/~bumblebee13Homepage: https://launchpad.net/~bumblebee
13Vcs-Git: git://anonscm.debian.org/pkg-nvidia/bumblebee.git14Vcs-Git: git://anonscm.debian.org/pkg-nvidia/bumblebee.git
@@ -16,7 +17,7 @@
16Package: bumblebee17Package: bumblebee
17Architecture: linux-any18Architecture: linux-any
18Depends: ${shlibs:Depends}, ${misc:Depends}, bbswitch-dkms | bbswitch-source19Depends: ${shlibs:Depends}, ${misc:Depends}, bbswitch-dkms | bbswitch-source
19Recommends: virtualgl | primus20Recommends: primus
20Suggests: bumblebee-nvidia (= ${binary:Version})21Suggests: bumblebee-nvidia (= ${binary:Version})
21Description: NVIDIA Optimus support for Linux22Description: NVIDIA Optimus support for Linux
22 Bumblebee is an effort to make NVIDIA Optimus enabled laptops work in23 Bumblebee is an effort to make NVIDIA Optimus enabled laptops work in
2324
=== modified file 'debian/rules'
--- debian/rules 2013-07-11 01:18:07 +0000
+++ debian/rules 2013-11-13 07:51:09 +0000
@@ -5,7 +5,7 @@
5#export DH_VERBOSE=15#export DH_VERBOSE=1
66
7%:7%:
8 dh $@ 8 dh $@ --with systemd
99
10override_dh_auto_configure:10override_dh_auto_configure:
11# Ubuntu and Debian's packaging of nvidia's proprietary driver differ greatly11# Ubuntu and Debian's packaging of nvidia's proprietary driver differ greatly

Subscribers

People subscribed via source and target branches