Code review comment for lp:~drizzle-pbxt/drizzle/drizzle-pbxt-2

I got this for insert_update test (./dtr --engine=pbxt):

--- /home/stewart/drizzle/drizzle-pbxt-2/tests/r/pbxt/insert_update.result 2009-05-28 15:55:48.726957481 +1000
+++ /home/stewart/drizzle/drizzle-pbxt-2/tests/r/pbxt/insert_update.reject 2009-05-29 14:01:43.915086845 +1000
@@ -58,12 +58,12 @@
 8 9 60 NULL
 explain extended SELECT *, VALUES(a) FROM t1;
 id select_type table type possible_keys key key_len ref rows filtered Extra
-1 SIMPLE t1 ALL NULL NULL NULL NULL 5 100.00
+1 SIMPLE t1 ALL NULL NULL NULL NULL 7 100.00
 Warnings:
 Note 1003 select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b`,`test`.`t1`.`c` AS `c`,values(`test`.`t1`.`a`) AS `VALUES(a)` from `test`.`t1`
 explain extended select * from t1 where values(a);
 id select_type table type possible_keys key key_len ref rows filtered Extra
-1 SIMPLE t1 ALL NULL NULL NULL NULL 5 100.00 Using where
+1 SIMPLE t1 ALL NULL NULL NULL NULL 7 100.00 Using where
 Warnings:
 Note 1003 select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b`,`test`.`t1`.`c` AS `c` from `test`.`t1` where values(`test`.`t1`.`a`)
 DROP TABLE t1;

and

--- /home/stewart/drizzle/drizzle-pbxt-2/tests/r/pbxt/type_enum.result 2009-05-20 21:41:41.506953655 +1000
+++ /home/stewart/drizzle/drizzle-pbxt-2/tests/r/pbxt/type_enum.reject 2009-05-29 14:09:57.670984523 +1000
@@ -1776,7 +1776,7 @@
 c
 EXPLAIN SELECT a FROM t1 WHERE a=0;
 id select_type table type possible_keys key key_len ref rows Extra
-1 SIMPLE t1 ALL NULL NULL NULL NULL 4 Using where
+1 SIMPLE t1 ALL NULL NULL NULL NULL 6 Using where
 SELECT a FROM t1 WHERE a=0;
 a
 ALTER TABLE t1 ADD PRIMARY KEY (a);

apart from that, I vote for merging:
- doesn't touch core (apart from us having to reslove the sql_string
c_ptr() thing)
- test fixes are all okay.
- code is quite likely to be actively maintained

--
Stewart Smith