Merge lp:~dreamhosters/txaws/921352-get-bucket-notification-method into lp:txaws
Proposed by
Arsene Rei
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Duncan McGreggor | ||||
Approved revision: | 137 | ||||
Merged at revision: | 129 | ||||
Proposed branch: | lp:~dreamhosters/txaws/921352-get-bucket-notification-method | ||||
Merge into: | lp:txaws | ||||
Diff against target: |
216 lines (+128/-6) 4 files modified
txaws/s3/client.py (+23/-1) txaws/s3/model.py (+9/-0) txaws/s3/tests/test_client.py (+85/-5) txaws/testing/payload.py (+11/-0) |
||||
To merge this branch: | bzr merge lp:~dreamhosters/txaws/921352-get-bucket-notification-method | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Duncan McGreggor | Approve | ||
Review via email:
|
Description of the change
Add GET Bucket notification functionality
To post a comment you must log in.
[1] Ah, I see you caught the docstrings from the previous merge -- nice :-)
[2] 180 + return succeed(payload. s3_get_ bucket_ notification_ with_topic_ result)
181 + sample_
Even with the long line, this doesn't following PEP 8. It should either be this:
return succeed(payload.
sample_ s3_get_ bucket_ notification_ with_topic_ result)
or this:
return succeed(
sample_ s3_get_ bucket_ notification_ with_topic_ result)
payload.
Visually, I'm happier with the first option ;-)
Tests pass, pep8/pyflakes look good.
Nice work! +1 for merge, once you decide how to handle #2 above.