lp:~dreamhosters/txaws/920309-fix-ca-certs

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:txaws

Arsene Rei: Approve on 2012-01-26

Jamu Kakar: Approve on 2012-01-26

Diff: 541 lines (+263/-146)

7 files modified

Makefile (+1/-1)
txaws/client/ssl.py (+44/-16)
txaws/client/tests/test_base.py (+8/-125)
txaws/client/tests/test_ssl.py (+199/-0)
txaws/exception.py (+6/-0)
txaws/s3/client.py (+1/-2)
txaws/s3/tests/test_acls.py (+4/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #920309: test_ssl_hostname_verification unit test error

Medium

Fix Released

Link a bug report

Related blueprints

133. By Duncan McGreggor on 2012-01-26

Fixed pep8 and pyflakes from some recent commits.

132. By Duncan McGreggor on 2012-01-26

Per Jamu's review comment, made the shell env var something distinctly
txAWS-ey.

131. By Duncan McGreggor on 2012-01-26

Fixed docstring from review feedback (by Stephon Striplin).

130. By Duncan McGreggor on 2012-01-26

* Filled in the test case for the get_ca_certs function.
* Moved the import of txaws.client.ssl to the module-level.
* Removed temp docstring created for removing pyflakes.

129. By Duncan McGreggor on 2012-01-26

Used trial.unittest.patch to modify a unit test that was failing on a system
with no .pem files in the certs directory.

128. By Duncan McGreggor on 2012-01-26

Changed the variable names to the more reasonable plural form.

127. By Duncan McGreggor on 2012-01-26

* Stubbed out unit tests for get_ca_certs.
* Renamed the txaws.client.base test module to reflect the name of the module
  that it's testing.
* Added a note about fixing the test_ssl_hostname_verification test.

126. By Duncan McGreggor on 2012-01-26

Split out ssl unit tests into their own test module.

125. By Duncan McGreggor on 2012-01-26

* Added a custom exception for certs not found.
* Added a check for the presence of any cert files; if not, raise an error
  (without this, an obscure Twisted exception is raised).

124. By Duncan McGreggor on 2012-01-26

Tweaked the get_ca_certs function pretty heavily.

The default is now specified at the module-level (DEFAULT_CERT_PATH), and this
is over-ridable with an environment variable (CERT_PATH). Each may contain
multiple paths, separated by colons.