Merge lp:~dpniel/ubuntu-manual-tests/nautilustestcase into lp:ubuntu-manual-tests

Proposed by Dan Chapman 
Status: Merged
Merged at revision: 104
Proposed branch: lp:~dpniel/ubuntu-manual-tests/nautilustestcase
Merge into: lp:ubuntu-manual-tests
Diff against target: 58 lines (+10/-6)
2 files modified
testcases/image/1337_Install (Default) (+1/-1)
testcases/packages/1424_Nautilus Tests (+9/-5)
To merge this branch: bzr merge lp:~dpniel/ubuntu-manual-tests/nautilustestcase
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+165083@code.launchpad.net

Description of the change

made changes to readability of nautilus testcase

To post a comment you must log in.
Revision history for this message
Javier López (javier-lopez) wrote :

Not sure if we should expect

dt>Select the 'App name' application, if not already selected</dt>

In my opinion, nautilus should select the right application for different files, otherwise, I should be threaten as a bug, other than that the changes look fine.

Revision history for this message
Dan Chapman  (dpniel) wrote :

My thoughts were the same at first, but after a quick test with an audio cd it came up with Rythmbox and Brasero as choices. It made me think that for some of community who are first time testing etc, being more explicit was a better option.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I agree Javier, it's a little funny with this auto-launch stuff. Let's go ahead and merge this change for now I think and see how it works out. We've gotten some confusing looks in the past over this, we'll see if this helps.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testcases/image/1337_Install (Default)'
2--- testcases/image/1337_Install (Default) 2013-03-28 20:24:31 +0000
3+++ testcases/image/1337_Install (Default) 2013-05-22 12:03:25 +0000
4@@ -10,7 +10,7 @@
5 <dt>Select the country of the keyboard</dt>
6 <dt>Select the keyboard layout</dt>
7 <dt>Select hostname ubuntu as default</dt>
8- <dt>Inser the name for the new user</dt>
9+ <dt>Insert the name for the new user</dt>
10 <dt>Insert the name for the account</dt>
11 <dt>Choose a password</dt>
12 <dt>Reinsert the password</dt>
13
14=== modified file 'testcases/packages/1424_Nautilus Tests'
15--- testcases/packages/1424_Nautilus Tests 2013-04-15 18:24:30 +0000
16+++ testcases/packages/1424_Nautilus Tests 2013-05-22 12:03:25 +0000
17@@ -195,7 +195,8 @@
18 This test will check that 'Open' dialog appears when plugging in a music device
19 <dt> Please ensure you have a USB drive available that contains music files and system under test has available USB ports. In addition it is assumed the Removable Media settings are unchanged from default, and will 'Ask what to do' for all media types when inserted.</dt>
20 <dt> Insert the player into the USB port of the system under tests and wait for new dialog to appear</dt>
21- <dd>'Open' dialog appears with 'Rhythmbox Music Player' application selected</dd>
22+ <dd>An 'Open' dialog window will appear offering you options.</dd>
23+ <dt>Select the 'Rhythmbox Music Player' application, if not already selected</dt>
24 <dt> Click OK button in the dialog box</dt>
25 <dd>Did Rhythmbox open with the Music Device displayed as a separate entry in the left panel tree?</dd>
26 </dl>
27@@ -205,7 +206,8 @@
28 This test will check that 'Open' dialog appears when inserting a DVD
29 <dt> Please ensure you have a Video DVD available and system under test has DVD drive. Also ensure you have installed dvd playback support in ubuntu (if needed for DRM DVD). In addition it is assumed the Removable Media settings are unchanged from default, and will 'Ask what to do' for all media types when inserted.</dt>
30 <dt> Insert the DVD into the DVD drive of the system under tests and wait for new dialog to appear</dt>
31- <dd>'Open' dialog appears with 'Movie Player (Totem)' application selected</dd>
32+ <dd>An 'Open' dialog window will appear offering you options.</dd>
33+ <dt>Select the 'Movie Player (Totem)' application, if not already selected</dt>
34 <dt> Click OK button in the dialog box</dt>
35 <dd>Did DVD playback start in Totem?</dd>
36 </dl>
37@@ -215,7 +217,8 @@
38 This test will check that 'Open' dialog appears on inserting an Audio CD
39 <dt> Please ensure you have an Audio CD available and system under test has CD drive. It is assumed the Removable Media settings are unchanged from default, and will 'Ask what to do' for all media types when inserted.</dt>
40 <dt> Insert the Audio CD into the CD drive of the system under tests and wait for new dialog to appear</dt>
41- <dd>'Open' dialog appears with 'Rhythmbox Music Player' application selected</dd>
42+ <dd>An 'Open' dialog window will appear offering you options.</dd>
43+ <dt>Select the 'Rhythmbox Music Player' application, if not already selected</dt>
44 <dt> Click OK button in the dialog box</dt>
45 <dd>Did Rhythmbox open with the Audio CD displayed in left panel tree?</dd>
46 </dl>
47@@ -224,8 +227,9 @@
48 <dl>
49 This test will check that 'Open' dialog appears on inserting a camera
50 <dt> Please ensure you have a camera available. It is assumed the Removable Media settings are unchanged from default, and will 'Ask what to do' for all media types when inserted.</dt>
51- <dt> Plug in the camera to the system under test and wait for new dialog to appear</dt>
52- <dd>'Open' dialog appears with 'Shotwell' application selected</dd>
53+ <dt> Plug in the camera to the system under test and wait for new dialog to appear.</dt>
54+ <dd>An 'Open' dialog window will appear offering you options.</dd>
55+ <dt>Select the 'Shotwell' application, if not already selected.</dt>
56 <dt> Click OK button in the dialog box</dt>
57 <dd>Did Shotwell open with the camera displayed in left panel tree?</dd>
58 </dl>

Subscribers

People subscribed via source and target branches