Merge lp:~dpniel/ubiquity/fix_1252215 into lp:ubiquity

Proposed by Dan Chapman 
Status: Merged
Merged at revision: 6066
Proposed branch: lp:~dpniel/ubiquity/fix_1252215
Merge into: lp:ubiquity
Diff against target: 20 lines (+4/-3)
1 file modified
autopilot/ubiquity_autopilot_tests/tests/__init__.py (+4/-3)
To merge this branch: bzr merge lp:~dpniel/ubiquity/fix_1252215
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Review via email: mp+195756@code.launchpad.net

Description of the change

Just a quick MP, during english installations set the location to London, to make it easier in the future to test the keyboard layouts don't break anything. Non-english still uses a random choice from London, Paris, Madrid and Algiers

To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

LTGM! Thanks.

review: Approve
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

*LGTM

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/ubiquity_autopilot_tests/tests/__init__.py'
2--- autopilot/ubiquity_autopilot_tests/tests/__init__.py 2013-11-19 09:07:08 +0000
3+++ autopilot/ubiquity_autopilot_tests/tests/__init__.py 2013-11-19 11:59:29 +0000
4@@ -540,13 +540,14 @@
5 "Expected location entry to be visible but it wasn't")
6
7 location = ['London', 'Paris', 'Madrid', 'Algiers']
8- location_page.select_location(random.choice(location))
9- self._check_page_titles()
10 if self.english_install:
11+ location_page.select_location('London')
12 self.eng_config = eng_label_values.stepLocation
13 self.expectThat(self.current_page_title,
14 Equals(self.eng_config['page_title']))
15-
16+ else:
17+ location_page.select_location(random.choice(location))
18+ self._check_page_titles()
19 self._check_navigation_buttons(continue_button=True, back_button=True,
20 quit_button=False, skip_button=False)
21

Subscribers

People subscribed via source and target branches

to status/vote changes: