Merge lp:~dpniel/ubiquity/fix-runner into lp:ubiquity

Proposed by Dan Chapman 
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 6316
Merged at revision: 6321
Proposed branch: lp:~dpniel/ubiquity/fix-runner
Merge into: lp:ubiquity
Diff against target: 72 lines (+40/-14)
2 files modified
autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/local/bin/run-autopilot.sh (+31/-14)
autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share/mate/autostart/autopilot.desktop (+9/-0)
To merge this branch: bzr merge lp:~dpniel/ubiquity/fix-runner
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Max Brustkern (community) Needs Fixing
Review via email: mp+270247@code.launchpad.net

Description of the change

Fixes the autopilot test runner for Ubuntu-GNOME and Ubuntu-MATE

To post a comment you must log in.
lp:~dpniel/ubiquity/fix-runner updated
6314. By Dan Chapman 

Remove --debug flag from run-autopilot.sh

Revision history for this message
Max Brustkern (nuclearbob) wrote :

This code appears to break the runner. I get a missing ;; in the logs. I can try proposing a patch after I test the other merge proposals.

review: Needs Fixing
lp:~dpniel/ubiquity/fix-runner updated
6315. By Dan Chapman 

Commit missing ;; in run-autopilot.sh

Revision history for this message
Dan Chapman  (dpniel) wrote :

Ooops!

This should be fixed now.

lp:~dpniel/ubiquity/fix-runner updated
6316. By Dan Chapman 

Seems I missed this when seperating my patches for commiting.

Sorry about that

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/local/bin/run-autopilot.sh'
2--- autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/local/bin/run-autopilot.sh 2015-08-25 16:19:22 +0000
3+++ autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/local/bin/run-autopilot.sh 2015-09-08 17:44:07 +0000
4@@ -61,20 +61,37 @@
5
6
7 # Specific configurations for various DE
8-case $SESSION in
9- ubuntu) # Covers Ubuntu and Edubuntu
10- SESSION_LOG=$HOME/.cache/upstart/gnome-session.log
11- ;;
12- xubuntu)
13- SESSION_LOG=$HOME/.cache/upstart/startxfce4.log
14- ;;
15- Lubuntu)
16- SESSION_LOG=$HOME/.cache/lxsession/Lubuntu/run.log
17- ARTIFACTS="$ARTIFACTS $HOME/.cache/lxsession"
18- ;;
19- gnome) # ubuntu-gnome
20- SESSION_LOG=$HOME/.cache/upstart/gnome-session.log
21-esac
22+if [ -n "${SESSION+1}" ]; then
23+ case $SESSION in
24+ ubuntu) # Covers Ubuntu and Edubuntu
25+ SESSION_LOG=$HOME/.cache/upstart/gnome-session.log
26+ ;;
27+ xubuntu)
28+ SESSION_LOG=$HOME/.cache/upstart/startxfce4.log
29+ ;;
30+ Lubuntu)
31+ SESSION_LOG=$HOME/.cache/lxsession/Lubuntu/run.log
32+ ARTIFACTS="$ARTIFACTS $HOME/.cache/lxsession"
33+ ;;
34+ esac
35+elif [ -n "${DESKTOP_SESSION+1}" ]; then
36+ # These 2 don't seem to log apt stuff to syslog
37+ # And there doesn't seem to be a user session log???
38+ # So let's tail it and also include in the artifacts
39+ case $DESKTOP_SESSION in
40+ mate) # Covers Ubuntu-mate
41+ SESSION_LOG=/var/log/apt/term.log
42+ ARTIFACTS="$ARTIFACTS /var/log/apt"
43+ ;;
44+ gnome) #ubuntu-gnome
45+ SESSION_LOG=/var/log/apt/term.log
46+ ARTIFACTS="$ARTIFACTS /var/log/apt"
47+ ;;
48+ esac
49+else
50+ echo "I: Unknown SESSION"
51+ exit 1
52+fi
53
54 PACKAGES="bzr ssh python3-autopilot libautopilot-gtk python3-xlib \
55 recordmydesktop"
56
57=== added directory 'autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share'
58=== added directory 'autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share/mate'
59=== added directory 'autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share/mate/autostart'
60=== added file 'autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share/mate/autostart/autopilot.desktop'
61--- autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share/mate/autostart/autopilot.desktop 1970-01-01 00:00:00 +0000
62+++ autopilot/ubiquity-autopilot-runner/custom-installation/iso-override/usr/share/mate/autostart/autopilot.desktop 2015-09-08 17:44:07 +0000
63@@ -0,0 +1,9 @@
64+[Desktop Entry]
65+Encoding=UTF-8
66+Name=Fire-up Autopilot tests for Ubiquity
67+Comment=Starts the Autopilot tests
68+Exec=/usr/local/bin/run-autopilot.sh -R
69+Terminal=false
70+Type=Application
71+Categories=
72+X-GNOME-Autostart-Delay=10

Subscribers

People subscribed via source and target branches

to status/vote changes: