Code review comment for lp:~dpm/ubuntu-weather-app/desktop-i18n-1325626-1318008

Revision history for this message
David Planella (dpm) wrote :

Thanks again for the review, I think I've now addressed all the comments:
- Added intltool installation instructions to the README file (I thought they should rather be there and not on README.translations, as this will affect the whole build - the app won't build without intltool)
- Added rule to copy the .desktop file
- On the last comment, we're already looking at qml files in the root folder (see the *.qml at the end of the highlighted line 35)

« Back to merge proposal