Code review comment for lp:~dpm/ubuntu-filemanager-app/include-plugin

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

20 + set(EXEC "qmlscene -qt5 qml/${MAIN_QML} -I ../plugin")

Prefer to use the upstart app launch set import dirs of lib/$arch/ and remove -I ../plugin"
If not set QT_IMPORTS_DIR will need to be set to this.

Additionally, and not related, I thought this project was forked from org.nemo but the copyright headers have:
197 + * Copyright 2014 Canonical Ltd.
198 + * Copyright 2014 Carlos J Mazieri <email address hidden>

and no trace of the original.

review: Needs Fixing

« Back to merge proposal