Merge lp:~dpm/ubuntu-calendar-app/refresh-translations into lp:ubuntu-calendar-app

Proposed by David Planella
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 125
Merged at revision: 123
Proposed branch: lp:~dpm/ubuntu-calendar-app/refresh-translations
Merge into: lp:ubuntu-calendar-app
Diff against target: 229 lines (+70/-46)
7 files modified
EventBubble.qml (+2/-0)
NewEvent.qml (+1/-1)
README (+0/-20)
README.translations (+20/-0)
calendar-app.qmlproject (+11/-0)
po/calendar-app.pot (+29/-25)
po/po.pro (+7/-0)
To merge this branch: bzr merge lp:~dpm/ubuntu-calendar-app/refresh-translations
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Olivier Tilloy (community) Approve
Review via email: mp+187705@code.launchpad.net

Commit message

Updated translatable strings, a couple of small fixes to ease translations

Description of the change

Updated translatable strings, a couple of small fixes to ease translations

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good, thanks David.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'EventBubble.qml'
2--- EventBubble.qml 2013-09-05 13:07:06 +0000
3+++ EventBubble.qml 2013-09-26 09:52:21 +0000
4@@ -38,6 +38,8 @@
5 var timeFormat = i18n.tr("hh:mm");
6 var startTime = event.startTime.toLocaleTimeString(Qt.locale(), timeFormat)
7 var endTime = event.endTime.toLocaleTimeString(Qt.locale(), timeFormat)
8+ // TRANSLATORS: the first argument (%1) refers to a start time for an event,
9+ // while the second one (%2) refers to the end time
10 var timeString = i18n.tr("%1 - %2").arg(startTime).arg(endTime)
11
12 timeLabel.text = ""
13
14=== modified file 'NewEvent.qml'
15--- NewEvent.qml 2013-08-30 08:24:51 +0000
16+++ NewEvent.qml 2013-09-26 09:52:21 +0000
17@@ -168,7 +168,7 @@
18 title: i18n.tr("Error")
19 text: ""
20 Button {
21- text: i18n.tr("Ok")
22+ text: i18n.tr("OK")
23 onClicked: PopupUtils.close(errorPopupDialog)
24 }
25 }
26
27=== modified file 'README'
28--- README 2013-06-17 17:30:33 +0000
29+++ README 2013-09-26 09:52:21 +0000
30@@ -7,23 +7,3 @@
31 $ qmlscene calendar.qml
32
33 To test the application on the device check out the "testrun.sh" script.
34-
35-# Updating translations
36-
37-Translations for the Calendar app happen in [Launchpad Translations][] and
38-are automatically committed daily on the trunk branch in the po/ folder.
39-
40-They are then built and installed as part of the package build, so that
41-developers don't really need to worry about them.
42-
43-However, there is one task that needs to be taken care of: exposing new
44-translatable messages to translators. So whenever you add new translatable
45-messages in the code, make sure to follow these steps:
46-
47- 1. Change directory to the po/ folder: `cd po`
48- 2. Update the translations template: `qmake && make pot`
49- 3. Commit the generated .pot file: `bzr commit -m"Updated translation template"`
50-
51-And that's it, Launchpad should take care of all the rest
52-
53- [Launchpad Translations]: https://translations.launchpad.net/ubuntu-calendar-app
54
55=== added file 'README.translations'
56--- README.translations 1970-01-01 00:00:00 +0000
57+++ README.translations 2013-09-26 09:52:21 +0000
58@@ -0,0 +1,20 @@
59+# Updating translations
60+
61+Translations for the Calendar app happen in [Launchpad Translations][] and
62+are automatically committed daily on the trunk branch in the po/ folder.
63+
64+They are then built and installed as part of the package build, so that
65+developers don't really need to worry about them.
66+
67+However, there is one task that needs to be taken care of: exposing new
68+translatable messages to translators. So whenever you add new translatable
69+messages in the code, make sure to follow these steps:
70+
71+ 1. Change directory to the po/ folder: `cd po`
72+ 2. Update the translations template: `qmake && make pot`
73+ 3. Commit the generated .pot file: `bzr commit -m"Updated translation template"`
74+ 4. Push the branch and send a merge proposal as usual
75+
76+And that's it, once the branch lands Launchpad should take care of all the rest!
77+
78+ [Launchpad Translations]: https://translations.launchpad.net/ubuntu-calendar-app
79
80=== modified file 'calendar-app.qmlproject'
81--- calendar-app.qmlproject 2013-07-18 18:44:27 +0000
82+++ calendar-app.qmlproject 2013-09-26 09:52:21 +0000
83@@ -15,6 +15,17 @@
84 ImageFiles {
85 directory: "."
86 }
87+ /* Shows the README files in the project view */
88+ Files {
89+ filter: "README*"
90+ }
91+ /* Shows the translation files and the .pro file used to generate the .pot template */
92+ Files {
93+ filter: "*.po*"
94+ }
95+ Files {
96+ filter: "*.pro"
97+ }
98 /* List of plugin directories passed to QML runtime */
99 importPaths: [ "." ,"/usr/lib/i386-linux-gnu/qt5/qml/", "/usr/lib/x86_64-linux-gnu/qt5/qml" ]
100 }
101
102=== modified file 'po/calendar-app.pot'
103--- po/calendar-app.pot 2013-08-30 08:25:04 +0000
104+++ po/calendar-app.pot 2013-09-26 09:52:21 +0000
105@@ -8,7 +8,7 @@
106 msgstr ""
107 "Project-Id-Version: calendar-app\n"
108 "Report-Msgid-Bugs-To: \n"
109-"POT-Creation-Date: 2013-08-30 10:23+0200\n"
110+"POT-Creation-Date: 2013-09-26 07:05+0200\n"
111 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
112 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
113 "Language-Team: LANGUAGE <LL@li.org>\n"
114@@ -19,24 +19,26 @@
115
116 #. TRANSLATORS: this is a time formatting string,
117 #. see http://qt-project.org/doc/qt-5.0/qtqml/qml-qtquick2-date.html#details for valid expressions
118-#: ../DayView.qml:29 ../TimeLineBackground.qml:22 ../TimeLineView.qml:103
119-#: ../WeekView.qml:27
120-msgid "HH"
121-msgstr ""
122-
123-#: ../DiaryView.qml:43
124-msgid "(+) New Event"
125-msgstr ""
126-
127-#: ../EventDetails.qml:69
128+#: ../EventBubble.qml:38
129+msgid "hh:mm"
130+msgstr ""
131+
132+#. TRANSLATORS: the first argument (%1) refers to a start time for an event,
133+#. while the second one (%2) refers to the end time
134+#: ../EventBubble.qml:43
135+#, qt-format
136+msgid "%1 - %2"
137+msgstr ""
138+
139+#: ../EventDetails.qml:70
140 msgid "Add invite"
141 msgstr ""
142
143-#: ../EventDetails.qml:75
144+#: ../EventDetails.qml:79
145 msgid "Edit"
146 msgstr ""
147
148-#: ../EventDetails.qml:150
149+#: ../EventDetails.qml:153
150 msgid "People"
151 msgstr ""
152
153@@ -68,8 +70,8 @@
154 msgid "Error"
155 msgstr ""
156
157-#: ../NewEvent.qml:171
158-msgid "Ok"
159+#: ../NewEvent.qml:171 ../TimePicker.qml:82
160+msgid "OK"
161 msgstr ""
162
163 #: ../NewEvent.qml:177
164@@ -80,6 +82,12 @@
165 msgid "End time can't be before start time"
166 msgstr ""
167
168+#. TRANSLATORS: this is a time formatting string,
169+#. see http://qt-project.org/doc/qt-5.0/qtqml/qml-qtquick2-date.html#details for valid expressions
170+#: ../TimeLineBackground.qml:18
171+msgid "hh ap"
172+msgstr ""
173+
174 #: ../TimePicker.qml:23
175 msgid "Time"
176 msgstr ""
177@@ -96,31 +104,27 @@
178 msgid "Cancel"
179 msgstr ""
180
181-#: ../TimePicker.qml:82
182-msgid "OK"
183-msgstr ""
184-
185-#: ../calendar.qml:52
186+#: ../calendar.qml:56
187 msgid "New Event"
188 msgstr ""
189
190-#: ../calendar.qml:60
191+#: ../calendar.qml:64
192 msgid "Today"
193 msgstr ""
194
195-#: ../calendar.qml:72
196+#: ../calendar.qml:75
197 msgid "Year"
198 msgstr ""
199
200-#: ../calendar.qml:93
201+#: ../calendar.qml:95
202 msgid "Month"
203 msgstr ""
204
205-#: ../calendar.qml:116
206+#: ../calendar.qml:108
207 msgid "Week"
208 msgstr ""
209
210-#: ../calendar.qml:132
211+#: ../calendar.qml:124
212 msgid "Day"
213 msgstr ""
214
215
216=== modified file 'po/po.pro'
217--- po/po.pro 2013-06-12 18:18:46 +0000
218+++ po/po.pro 2013-09-26 09:52:21 +0000
219@@ -1,3 +1,10 @@
220+## This .pro file is used to create a Makefile with the necessary rules
221+## to create an initial translations template and to update it whenever
222+## there are new translatable strings in the project that are ready to be
223+## exposed to translators
224+##
225+## See the ../README.translations file for more information
226+
227 TEMPLATE = subdirs
228
229 PROJECTNAME = $$system(basename ../*.qmlproject)

Subscribers

People subscribed via source and target branches

to status/vote changes: