Merge lp:~dpm/ubuntu-calendar-app/package-translations into lp:ubuntu-calendar-app

[David Planella]

Add support for building and installing translations in the package.

This branch adds support for building and installing translations in the package.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:35
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/16/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/16

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/16/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

26 + localedir="debian/$$appname/usr/share/locale/$$langcode/LC_MESSAGES"; \
27 + mkdir -p $$localedir; \
28 + mofile="$$localedir/$$appname.mo"; \
29 + msgfmt -o $$mofile $$pofile; \

Wouldn’t it be cleaner to invoke dh_install with the generated mo file and the destination directory? E.g. something like that (not tested):

    localedir="usr/share/locale/$$langcode/LC_MESSAGES"; \
    mofile="$$appname.mo"; \
    msgfmt -o $$mofile $$pofile; \
    dh_install $$mofile $$localedir; \

[lp:~dpm/ubuntu-calendar-app/package-translations]

36. By David Planella on 2013-06-17

Changed package installation rule as per feedback from Olivier Tilloy

[David Planella (dpm)]

I've gone ahead and implemented the suggestion. I'm aware that the right way to package this would probably be to have a top level .pro file and a .mo file creation rule in po/po.pro, and not do it on debian/rules. However, this is just a first iteration to keep the packaging simple and we'll update the packaging properly for all core apps in a subsequent iteration.

I've noticed one thing in implementing your suggestion: there is an ubuntu-calendar-app.mo file created on the top level dir as a product of package building, which is not removed by debuild clean. Any ideas how to get this file cleaned up/not created in the first place?

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:36
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/27/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/12
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/27

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/27/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

> I've noticed one thing in implementing your suggestion: there is an ubuntu-
> calendar-app.mo file created on the top level dir as a product of package
> building, which is not removed by debuild clean. Any ideas how to get this
> file cleaned up/not created in the first place?

No idea, but I’ll give it a quick look.

[Olivier Tilloy (osomon)]

> > I've noticed one thing in implementing your suggestion: there is an ubuntu-
> > calendar-app.mo file created on the top level dir as a product of package
> > building, which is not removed by debuild clean. Any ideas how to get this
> > file cleaned up/not created in the first place?

Found it, just add this line at the end of the for loop, after the call to dh_install:

    rm -f $$mofile; \

[lp:~dpm/ubuntu-calendar-app/package-translations]

37. By David Planella on 2013-06-17

Cleaned up generated .mo files as part of the package installation

[Olivier Tilloy (osomon)]

Looks good, thanks!

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:37
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/28/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-quantal-amd64-ci/13
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-calendar-app-raring-amd64-ci/28

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/28/rebuild

review: Approve (continuous-integration)

=== modified file 'debian/changelog'
--- debian/changelog	2013-04-04 21:27:58 +0000
+++ debian/changelog	2013-06-17 10:52:26 +0000
@@ -1,3 +1,9 @@
+ubuntu-calendar-app (0.3) raring; urgency=low
+
+  * Updated packaging to install translations
+
+ -- David Planella <[e-mail]>  Tue, 28 May 2013 13:53:10 +0200
+
 ubuntu-calendar-app (0.2) raring; urgency=low
 
   * Changing the app name so it can be closed by the hud (LP: #1164130).

=== modified file 'debian/rules'
--- debian/rules	2013-04-11 19:47:11 +0000
+++ debian/rules	2013-06-17 10:52:26 +0000
@@ -9,3 +9,13 @@
 
 override_dh_install:
 	dh_install --fail-missing
+	appname=ubuntu-calendar-app; \
+	for pofile in $(shell find ./po -name "*.po"); do \
+		pofilename="$${pofile##*/}"; \
+		langcode="$${pofilename%.*}"; \
+		localedir="usr/share/locale/$$langcode/LC_MESSAGES"; \
+		mofile="$$appname.mo"; \
+		msgfmt -o $$mofile $$pofile; \
+		dh_install $$mofile $$localedir; \
+		rm -f $$mofile; \
+	done