Merge lp:~dpm/reminders-app/workaround-for-1351041 into lp:reminders-app

Proposed by David Planella
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 211
Merged at revision: 211
Proposed branch: lp:~dpm/reminders-app/workaround-for-1351041
Merge into: lp:reminders-app
Diff against target: 23 lines (+7/-3)
1 file modified
src/app/qml/reminders.qml (+7/-3)
To merge this branch: bzr merge lp:~dpm/reminders-app/workaround-for-1351041
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Riccardo Padovani Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+229753@code.launchpad.net

Commit message

Workaround for bug 1351041, in which we fetch the hostname somewhere else in the code to get valid results.

Click package for testing purposes available at:
http://people.canonical.com/~dpm/click/com.ubuntu.reminders_0.5.204_armhf.click

Description of the change

Workaround for bug 1351041, in which we fetch the hostname somewhere else in the code to get valid results.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Tested this on my nexus 4 and it fixes the issue.

review: Approve
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Tested on my mako, works fine.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml 2014-07-23 21:39:44 +0000
+++ src/app/qml/reminders.qml 2014-08-06 09:47:49 +0000
@@ -135,12 +135,16 @@
135135
136 AccountService {136 AccountService {
137 id: accountService137 id: accountService
138 onObjectHandleChanged: authenticate(null);138 onObjectHandleChanged: {
139 // FIXME: workaround for lp:1351041. We'd normally set the hostname
140 // under onAuthenticated, but it seems that now returns empty parameters
141 EvernoteConnection.hostname = accountService.authData.parameters["HostName"];
142 authenticate(null);
143 }
139 onAuthenticated: {144 onAuthenticated: {
140 if (EvernoteConnection.token && EvernoteConnection.token != reply.AccessToken) {145 if (EvernoteConnection.token && EvernoteConnection.token != reply.AccessToken) {
141 EvernoteConnection.clearToken();146 EvernoteConnection.clearToken();
142 }147 }
143 EvernoteConnection.hostname = accountService.authData.parameters["HostName"];
144 EvernoteConnection.token = reply.AccessToken;148 EvernoteConnection.token = reply.AccessToken;
145 }149 }
146 onAuthenticationError: {150 onAuthenticationError: {

Subscribers

People subscribed via source and target branches