Merge lp:~dpm/reminders-app/translator-comments into lp:reminders-app

[David Planella]

Provide more context to translators when translating a date string.

Provide more context to translators when translating a date string.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:157
http://91.189.93.70:8080/job/reminders-app-ci/383/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2907/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2907/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/436
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/436/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-ci/384
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/78

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/383/rebuild

review: Needs Fixing (continuous-integration)

[Riccardo Padovani (rpadovani)]

Mhh, why translators have to translate this string? QLocale doesn't automatic work to understand what language is and provide right translation?

And if not, what could be the translation of this string?

review: Needs Information

[Michael Zanetti (mzanetti)]

I agree with Riccardo... This is not really something that should (or can) be translated... Actually the gettext should go away...

review: Disapprove

[Michael Zanetti (mzanetti)]

To be clear, QLocale::standaloneMonthName should give us the month already translated. If it doesn't we probably have an issue that we're not loading the Qt translations.

[David Planella (dpm)]

I'm up for leaving this as not translatable and let Qt provide the right translation, I always prefer that approach. The reason I understand it's marked for translation right now is to let languages which need it to rearrange the year and month differently than "month, year".

I just added the translator comment to make it clear, as I saw it while doing the translation. So if there is a Qt Locale format that gives this same output format without the need of translators to rearrange it, I'm all up for it.

[Michael Zanetti (mzanetti)]

After having a chat on IRC it turns out I'm wrong and this is legit indeed. Comment is fine.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/145/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2910/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2910/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/441
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/441/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-autolanding/145
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/37

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/146/
Executed test runs:
    None: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2927/console
    None: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-autolanding/146/console
    None: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/38/console

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/147/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/495
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/495/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/39

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'src/plugin/Evernote/note.cpp'
--- src/plugin/Evernote/note.cpp	2014-05-09 13:02:38 +0000
+++ src/plugin/Evernote/note.cpp	2014-06-06 09:29:24 +0000
@@ -91,6 +91,7 @@
         return gettext("Two weeks ago");
     }
 
+    // TRANSLATORS: the first argument refers to a month name and the second to a year
     return QString(gettext("%1 %2")).arg(QLocale::system().standaloneMonthName(createdDate.month())).arg(createdDate.year());
 }