Merge lp:~dpm/reminders-app/fix-1303763 into lp:reminders-app

Proposed by David Planella
Status: Merged
Approved by: David Planella
Approved revision: 108
Merged at revision: 104
Proposed branch: lp:~dpm/reminders-app/fix-1303763
Merge into: lp:reminders-app
Prerequisite: lp:~dpm/reminders-app/qtc-changes
Diff against target: 31 lines (+3/-2)
2 files modified
manifest.json (+1/-1)
src/app/main.cpp (+2/-1)
To merge this branch: bzr merge lp:~dpm/reminders-app/fix-1303763
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Leo Arias (community) tried the new package Approve
Michael Zanetti (community) Approve
Review via email: mp+214952@code.launchpad.net

Commit message

Adds the launch path to those searched for when looking for the main QML file, so that the app can start.

Description of the change

Adds the launch path to those searched for when looking for the main QML file, so that the app can start.

To post a comment you must log in.
lp:~dpm/reminders-app/fix-1303763 updated
107. By David Planella

No need to re-bump the version number

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Hmm... I think the change that introduced the applicationPath() also changed autopilot to rely on that. I think we should probably keep that too.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

clarified on IRC. seems allright.

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Good point. Checked that and running 'autopilot run reminders' from the tests/autopilot directory, and that seemed to work well. I.e. it ran successfully the one test we have.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) :
review: Approve (tried the new package)
lp:~dpm/reminders-app/fix-1303763 updated
108. By David Planella

Merged prerequisite branch changes to fix Debian packaging and allow Jenkins to build packages

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'manifest.json'
--- manifest.json 2014-04-09 20:01:58 +0000
+++ manifest.json 2014-04-09 20:01:58 +0000
@@ -19,4 +19,4 @@
19 "x-test": {19 "x-test": {
20 "autopilot": "reminders"20 "autopilot": "reminders"
21 }21 }
22}
23\ No newline at end of file22\ No newline at end of file
23}
2424
=== modified file 'src/app/main.cpp'
--- src/app/main.cpp 2014-04-01 10:38:24 +0000
+++ src/app/main.cpp 2014-04-09 20:01:58 +0000
@@ -27,6 +27,7 @@
27#include <QtQuick/QQuickView>27#include <QtQuick/QQuickView>
28#include <QtQml/QtQml>28#include <QtQml/QtQml>
29#include <QLibrary>29#include <QLibrary>
30#include <QDir>
3031
31#include <QDebug>32#include <QDebug>
3233
@@ -103,7 +104,7 @@
103 QString qmlfile;104 QString qmlfile;
104 const QString filePath = QLatin1String("qml/reminders.qml");105 const QString filePath = QLatin1String("qml/reminders.qml");
105 QStringList paths = QStandardPaths::standardLocations(QStandardPaths::DataLocation);106 QStringList paths = QStandardPaths::standardLocations(QStandardPaths::DataLocation);
106 paths.prepend(QCoreApplication::applicationDirPath());107 paths.prepend(QDir::currentPath());
107 Q_FOREACH (const QString &path, paths) {108 Q_FOREACH (const QString &path, paths) {
108 QString myPath = path + QLatin1Char('/') + filePath;109 QString myPath = path + QLatin1Char('/') + filePath;
109 if (QFile::exists(myPath)) {110 if (QFile::exists(myPath)) {

Subscribers

People subscribed via source and target branches