Merge lp:~dpm/messaging-app/i18n-send into lp:messaging-app

Proposed by David Planella
Status: Superseded
Proposed branch: lp:~dpm/messaging-app/i18n-send
Merge into: lp:messaging-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/qml/Messages.qml (+1/-1)
To merge this branch: bzr merge lp:~dpm/messaging-app/i18n-send
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+228941@code.launchpad.net

This proposal has been superseded by a proposal from 2014-08-28.

Commit message

Mark the "Send" string for translation.

Description of the change

Mark the "Send" string for translation. This will require an update of the .pot file too.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

Thanks David. We need somebody to top approve this.

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

Oh David, on the other branch you mentioned that the branch should also update the pot.
Is that with make messaging-app.pot ?

Revision history for this message
Albert Astals Cid (aacid) wrote :
Revision history for this message
Albert Astals Cid (aacid) wrote :

And since now my branch as been discarded, no this should not be discarded.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2014-07-25 20:19:45 +0000
3+++ src/qml/Messages.qml 2014-07-30 20:53:47 +0000
4@@ -947,7 +947,7 @@
5 anchors.bottom: parent.bottom
6 anchors.right: parent.right
7 anchors.rightMargin: units.gu(2)
8- text: "Send"
9+ text: i18n.tr("Send")
10 color: "green"
11 width: units.gu(7)
12 height: units.gu(4)

Subscribers

People subscribed via source and target branches