Merge lp:~bfiller/messaging-app/i18n-send into lp:messaging-app

Proposed by Bill Filler
Status: Merged
Approved by: Bill Filler
Approved revision: 169
Merged at revision: 204
Proposed branch: lp:~bfiller/messaging-app/i18n-send
Merge into: lp:messaging-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/qml/Messages.qml (+1/-1)
To merge this branch: bzr merge lp:~bfiller/messaging-app/i18n-send
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
PS Jenkins bot continuous-integration Pending
Leo Arias Pending
Review via email: mp+232591@code.launchpad.net

This proposal supersedes a proposal from 2014-07-30.

Commit message

Mark the "Send" string for translation. This will require an update of the .pot file too.

Description of the change

Mark the "Send" string for translation. This will require an update of the .pot file too.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Thanks David. We need somebody to top approve this.

review: Approve
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Oh David, on the other branch you mentioned that the branch should also update the pot.
Is that with make messaging-app.pot ?

Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

And since now my branch as been discarded, no this should not be discarded.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2014-08-20 15:34:00 +0000
3+++ src/qml/Messages.qml 2014-08-28 16:18:33 +0000
4@@ -913,7 +913,7 @@
5 anchors.bottom: parent.bottom
6 anchors.right: parent.right
7 anchors.rightMargin: units.gu(2)
8- text: "Send"
9+ text: i18n.tr("Send")
10 color: enabled ? "#38b44a" : "#b2b2b2"
11 width: units.gu(7)
12 height: units.gu(4)

Subscribers

People subscribed via source and target branches