Merge lp:~dpm/help-app/question-navigation into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by David Planella
Status: Merged
Approved by: David Planella
Approved revision: 82
Merged at revision: 88
Proposed branch: lp:~dpm/help-app/question-navigation
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 83 lines (+14/-2)
5 files modified
edit-here/content/pages/settings.md (+1/-0)
edit-here/pelicanconf.py (+2/-0)
edit-here/themes/web/templates/_head.html (+8/-0)
edit-here/themes/web/templates/_header.html (+1/-1)
edit-here/themes/web/templates/base.html (+2/-1)
To merge this branch: bzr merge lp:~dpm/help-app/question-navigation
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+252414@code.launchpad.net

Description of the change

Added list of questions at the top of each page for easy navigation via the toc python-markdown extension.

Web theme: removed all non-essential CSS and JS files for easier debugging. Reverted to online-only assets for now, will go back to offline assets later.

Known issues:
- I've only added the TOC to one of the content files. If it works well, I'll add it to the rest.
- This puts the [TOC] marker in the .pot file, which is likely to be broken by translators:

#. type: Plain text
#: content/pages/settings.md:6
msgid "[TOC]"
msgstr ""

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Great work!

Should be easy to maintain and easy to use. Here's the necessary fix in translations.py:

https://code.launchpad.net/~dholbach/help-app/question-navigation.fixes/+merge/252431

Revision history for this message
Daniel Holbach (dholbach) wrote :

If you can approve and merge the fix, I'm happy for this to get landed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'edit-here/content/pages/settings.md'
2--- edit-here/content/pages/settings.md 2015-03-09 14:59:58 +0000
3+++ edit-here/content/pages/settings.md 2015-03-10 11:02:31 +0000
4@@ -2,6 +2,7 @@
5
6 *How do I change my phone settings?*
7
8+[TOC]
9
10 ### How do I update my system?
11 Your device will prompt you when an update is ready. A notification will appear informing you of the new update. If you wish, you can manually check and perform an update yourself. Open the *System Settings* application. Select *Update*, and then click the check for updates button.
12
13=== modified file 'edit-here/pelicanconf.py'
14--- edit-here/pelicanconf.py 2015-02-26 15:45:19 +0000
15+++ edit-here/pelicanconf.py 2015-03-10 11:02:31 +0000
16@@ -43,3 +43,5 @@
17 TAGS_SAVE_AS = ''
18 TAG_SAVE_AS = ''
19 THEME = 'themes/phone'
20+
21+MD_EXTENSIONS = ['toc']
22
23=== added directory 'edit-here/themes/web/static/js/plugins'
24=== renamed file 'edit-here/themes/web/static/js/Imager.js' => 'edit-here/themes/web/static/js/plugins/Imager.js'
25=== renamed file 'edit-here/themes/web/static/js/modernizr.2.7.1.js' => 'edit-here/themes/web/static/js/plugins/modernizr.2.7.1.js'
26=== modified file 'edit-here/themes/web/templates/_head.html'
27--- edit-here/themes/web/templates/_head.html 2015-03-09 15:48:23 +0000
28+++ edit-here/themes/web/templates/_head.html 2015-03-10 11:02:31 +0000
29@@ -6,12 +6,20 @@
30 <link rel="shortcut icon" href="{{ THEME_STATIC_DIR }}/img/favicon.ico" type="image/x-icon" />
31
32 <!-- stylesheets -->
33+ <!--
34 <link rel="stylesheet" type="text/css" media="all" href="{{ THEME_STATIC_DIR }}/css/ubuntu-styles.css"/>
35 <link rel="stylesheet" type="text/css" media="screen" href="{{ THEME_STATIC_DIR }}/css/styles.css" />
36 <link rel="stylesheet" type="text/css" media="screen" href="{{ THEME_STATIC_DIR }}/css/global-responsive.css" />
37 <link rel="stylesheet" type="text/css" media="print" href="{{ THEME_STATIC_DIR }}/css/core-print.css" />
38+ -->
39+ <link rel="stylesheet" type="text/css" media="all" href="http://assets.ubuntu.com/sites/guidelines/css/latest/ubuntu-styles.css"/>
40+ <link rel="stylesheet" type="text/css" media="all" href="{{ THEME_STATIC_DIR }}/css/help-app.css" />
41
42 <!-- javascript -->
43+
44 <script src="{{ THEME_STATIC_DIR }}/js/plugins/modernizr.2.7.1.js"></script>
45 <script src="{{ THEME_STATIC_DIR }}/js/plugins/Imager.js"></script>
46
47+ <script src="http://assets.ubuntu.com/sites/ubuntu/latest/u/js/plugins/yui-min.js"></script>
48+ <script src="http://assets.ubuntu.com/sites/ubuntu/latest/u/js/core.js"></script>
49+
50
51=== modified file 'edit-here/themes/web/templates/_header.html'
52--- edit-here/themes/web/templates/_header.html 2015-03-09 15:48:23 +0000
53+++ edit-here/themes/web/templates/_header.html 2015-03-10 11:02:31 +0000
54@@ -1,7 +1,7 @@
55 <nav role="navigation" class="nav-primary nav-right">
56 <div class="logo">
57 <a class="logo-ubuntu" href="/">
58- <img width="106" height="25" src="{{ THEME_STATIC_DIR }}/img/llogo-ubuntu-orange.svg" alt="" />
59+ <img width="106" height="25" src="{{ THEME_STATIC_DIR }}/img/logo-ubuntu-orange.svg" alt="" />
60 <span>help</span>
61 </a>
62 </div>
63
64=== modified file 'edit-here/themes/web/templates/base.html'
65--- edit-here/themes/web/templates/base.html 2015-03-09 14:59:58 +0000
66+++ edit-here/themes/web/templates/base.html 2015-03-10 11:02:31 +0000
67@@ -34,6 +34,7 @@
68 </footer>
69
70 <!-- Use this only until Modernizr fixes Opera Mini background-size detection -->
71+<!--
72 <script>
73 var isOperaMini = (navigator.userAgent.indexOf('Opera Mini') > -1);
74 if(isOperaMini) {
75@@ -73,7 +74,7 @@
76 var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
77 })();
78 </script>
79-
80+-->
81 </body>
82
83 </html>

Subscribers

People subscribed via source and target branches