Code review comment for lp:~dpigott/lava-dispatcher/add-bootloader-support
Revision history for this message
| Dave Pigott (dpigott) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On 20 Nov 2012, at 17:05, Andy Doan <email address hidden> wrote:
> On 11/20/2012 10:58 AM, Dave Pigott wrote:
>> Ok. So what you're saying is that to support this, we need to accept a selection in the JSON file, and then use the read-hwpack option to determine if it's valid. If nothing is specified we use the first in the list for the matching device type.
>>
>> That's probably enough to push it into backlog, to be honest. If my change is unsupportable, then let's just throw it away,
>
> Fathi and I discussed on IRC. I think what you have now is good. I don't think we need to do validation of the bootloader parameter. we'll put the responsibility on the user for now. In the, likely near, future we can do Fathi's suggesion and validated (or automatically choose) based on this l-m-c command.
Cool.