Code review comment for lp:~dpigott/lava-dispatcher/add-bootloader-support

Revision history for this message
Dave Pigott (dpigott) wrote :

Ok. So what you're saying is that to support this, we need to accept a selection in the JSON file, and then use the read-hwpack option to determine if it's valid. If nothing is specified we use the first in the list for the matching device type.

That's probably enough to push it into backlog, to be honest. If my change is unsupportable, then let's just throw it away,

On 20 Nov 2012, at 16:01, Fathi Boudra <email address hidden> wrote:

> On 20 November 2012 17:48, Andy Doan wrote:
>> On 11/20/2012 07:47 AM, Fathi Boudra wrote:
>>>
>>> It's worth mentioning that 'u_boot' is just a string and can be anything.
>>> You can use linaro-media-create --read-hwpack to get the supported
>>> bootloaders and pass a valid string.
>>
>> Yes, but that should only matter if we are auto-guessing for the user,
>> right? Can we just get away with requiring users to provide the bootloader
>> they want in the event its not u-boot?
>
> You're already guessing that the default bootloader is U-Boot and its
> label is called 'u_boot'.
> I don't think you have to guess as the hwpack provides the default
> bootloader and also the label.
> No interaction with the user here.
>
> --
> https://code.launchpad.net/~dpigott/lava-dispatcher/add-bootloader-support/+merge/135151
> You are the owner of lp:~dpigott/lava-dispatcher/add-bootloader-support.

« Back to merge proposal