Code review comment for lp:~dpigott/lava-dispatcher/add-bootloader-support

Revision history for this message
Dave Pigott (dpigott) wrote :

Yeah, I checked thoroughly, because I prefer to have function parameters in a logical sequence.

Sent from my Aldis Lamp

On 20 Nov 2012, at 15:46, Andy Doan <email address hidden> wrote:

> seems okay. In general I'm a little uncomfortable with inserting a function parameter rather than appending it to the list. However, it looks like you grep'd through code and fixed all the references where this was affected.
> --
> https://code.launchpad.net/~dpigott/lava-dispatcher/add-bootloader-support/+merge/135151
> You are the owner of lp:~dpigott/lava-dispatcher/add-bootloader-support.

« Back to merge proposal