Code review comment for lp:~dpigott/lava-dispatcher/add-bootloader-support

Revision history for this message
Dave Pigott (dpigott) wrote :

I know, and I thought long and hard about which was the right way to go. At the end of the day, the solution was much more flexible this way, since you can also get a return such as:

+--------------------------------------+--------------------------------------+
Supported boards | Supported bootloaders
+--------------------------------------+--------------------------------------+
linaro-vexpress | uefi,u_boot
+--------------------------------------+--------------------------------------+

It would not be possible to decide which one to pick.

This way, the person or process creating and submitting jobs is responsible for picking the right one, and if new ones get added, then those just get done as well.

There will probably be some other work to do in the way the lava dispatcher handles things when interrupting boot, but that's not a problem when sd-mux arrives.

« Back to merge proposal