Code review comment for lp:~dpb/orange-box/use-nc-not-ping-1361714

Revision history for this message
David Britton (dpb) wrote :

Thanks Dustin --

I believe I've addressed all the feedback except one thing,

orange-box-test-uplink already does a timeout and run-one-until-success, you would like another wrapper around that? You think there should be a timeout associated too? One issue I noticed is that it was waiting forever which seemed odd for a postinst.

Thoughts?

And ya, timeout is pretty rad. got rid of so many boilerplate loops in my shell scripts. :)

« Back to merge proposal