Merge lp:~dpb/lp2kanban/lint-1 into lp:lp2kanban

[David Britton]

Add lint target (flake8), remove lint.

Add lint target (flake8), remove lint.

make lint should pass
make ci-test includes lint check

[🤖 Landscape Builder (landscape-builder)]

review: Abstain (executing tests)

[🤖 Landscape Builder (landscape-builder)]

Command: http_proxy=$CI_PROXY https_proxy=$CI_PROXY make ci-test
Result: Success
Revno: 178
Branch: lp:~davidpbritton/lp2kanban/lint-1
Jenkins: https://ci.lscape.net/job/latch-test/10190/

review: Approve (test results)

[Alberto Donato (ack)]

nice! +1

review: Approve

=== modified file 'Makefile'
--- Makefile	2016-08-29 20:19:31 +0000
+++ Makefile	2016-09-08 22:02:56 +0000
@@ -61,4 +61,7 @@
 	. venv/bin/activate; \
 	$(MAKE) check
 
-.PHONY: check default configs needs-xdg-utils clean ci-test
+lint:
+	flake8 src/lp2kanban
+
+.PHONY: check default configs needs-xdg-utils clean ci-test lint
 
=== modified file 'src/lp2kanban/bugs2cards.py'
--- src/lp2kanban/bugs2cards.py	2016-09-08 22:02:56 +0000
+++ src/lp2kanban/bugs2cards.py	2016-09-08 22:02:56 +0000
@@ -141,7 +141,7 @@
             self.lp_to_group.update(parse_groups_config(groups_config))
 
         self.feature_lanes = {}
-        new_lane =  config.get("new_lanes")
+        new_lane = config.get("new_lanes")
         if not new_lane:
             return
         if "${group}" in new_lane:
@@ -149,7 +149,7 @@
             for group in set(self.lp_to_group.values()):
                 lane_path = new_lane.replace("${group}", group)
                 lane = board.getLaneByPath(lane_path)
-                group_tag = "squad-%s" % group.lower().replace(" ","-")
+                group_tag = "squad-%s" % group.lower().replace(" ", "-")
                 self.feature_lanes[group_tag] = lane
         for card in board.getFeatureCards():
             if not card.tags:
@@ -192,6 +192,7 @@
 IGNORE_STATUSES = ('Superseded',)
 FINAL_STATUSES = ('Approved', 'Merged')
 
+
 def get_lp_bug(card, launchpad):
     """Return the launchpad bug resource for a card if that bug exists.
 
@@ -273,7 +274,7 @@
 
     for card in feature_card.lane.board.cards:
         if card_type and card.type.name != card_type:
-             continue
+            continue
         if card.tags:
             card_tags = set(card.tags.split(","))
             if feature_tags.intersection(card_tags):
@@ -304,7 +305,7 @@
         mps = []
         has_inprogress_branches = False
         for branch in branches:
-            if hasattr(branch, 'branch') :
+            if hasattr(branch, 'branch'):
                 branch = branch.branch
             for mp in branch.landing_targets:
                 mp_info = Record(rank=None, status=None, mp=None)
@@ -319,7 +320,7 @@
                 mps.append(mp_info)
         if len(mps) == 0:
             return None
-        mps.sort(key=lambda x:(x.rank, x.mp.date_created), reverse=True)
+        mps.sort(key=lambda x: (x.rank, x.mp.date_created), reverse=True)
         if not has_inprogress_branches:
             return mps[0]  # Return highest-ranked and most-recent MP
         for mp in mps:
@@ -395,7 +396,7 @@
         return False
     if card.tags and "no-sync" in set(card.tags.split(",")):
         return False
-   
+
     enabled = conf.get('move_cards', 'off') == 'on'
     active = not card.lane.board.is_archived
     return enabled and active
@@ -498,7 +499,7 @@
                 status = CardStatus.LANDING
         elif branch_card_status:
             return branch_card_status
-            
+
     elif bug_status in DONE_FIX_BUG_STATUSES:
         status = CardStatus.DONE_FIX
     elif bug_status in DONE_NOFIX_BUG_STATUSES:
@@ -512,7 +513,7 @@
         if task.target in all_projects:
             return True
         if (hasattr(task.target, "project") and
-            task.target.project in all_projects):
+                task.target.project in all_projects):
             return True
     return False
 
@@ -525,13 +526,13 @@
     for task in tasks:
         # Ignore bug task status for series targets
         if (task.target.resource_type_link == RESOURCE_TYPE_LINK_SERIES and
-            task.target.project in all_projects):
+                task.target.project in all_projects):
             continue  # Skip series task status for our projects
         if (task.assignee is not None and
-            task.assignee.name not in all_users):
+                task.assignee.name not in all_users):
             continue  # Skip non-users tasks
         if (task.target in all_projects or
-            task.assignee is not None):
+                task.assignee is not None):
             matches = True
             if (lowest_status is None or
                 (ORDERED_BUG_STATUSES.index(task.status) <
@@ -555,7 +556,6 @@
             return possible_target_lane
 
 
-
 def find_card_target_lane_next(lane, path):
     """Find the target lane for the path using the "next" algorithm.
 
@@ -723,7 +723,7 @@
                 assignee = Record(name=owner_name)
                 try:
                     move_card(card, card_status, bconf, [assignee], lp_users)
-                except IOError as e:
+                except IOError:
                     log.exception("Error moving card: %s (in %s)" % (
                         card.title, card_path))
                     continue
@@ -751,7 +751,8 @@
                 continue
             ignore_external_projects = (
                 bconf.get("autosync") == "active-projects")
-            if ignore_external_projects and not is_bug_in_projects(lp_bug, lp_projects):
+            if ignore_external_projects and not is_bug_in_projects(
+                    lp_bug, lp_projects):
                 continue  # Skip bugs in external projects
             synced, card_status, assignees, mp_url, mp_type = get_bug_status(
                 lp_bug, lp_projects, lp_users.lp_to_kanban.keys())
@@ -766,7 +767,7 @@
             if card_status is not None and should_move_card(card, bconf):
                 try:
                     move_card(card, card_status, bconf, assignees, lp_users)
-                except IOError as e:
+                except IOError:
                     log.exception("Error Moving: lp:%s: %s (in %s)" % (
                         lp_bug.id, card.title, card_path))
                     continue
@@ -878,7 +879,8 @@
         return
 
     log.info(
-        u" * Moving card#{}: {} -> {}".format(card.id, card.lane.path, target_lane_path))
+        u" * Moving card#{}: {} -> {}".format(
+            card.id, card.lane.path, target_lane_path))
     card.move(target_lane)
 
 
@@ -896,8 +898,8 @@
         # happens.
         try:
             card.save()
-        except IOError as e:
-            log.exception(u"Exception caught.  Skipping board.\n"
+        except IOError:
+            log.exception("Exception caught.  Skipping board.\n"
                           "  desc:{}\n"
                           "  kanban id:{}\n"
                           "  LP bug id:{}\n".format(
@@ -937,7 +939,8 @@
 
     if args.debug:
         logging.basicConfig(
-            level=logging.DEBUG, format='%(asctime)s %(levelname)s %(message)s')
+            level=logging.DEBUG,
+            format='%(asctime)s %(levelname)s %(message)s')
         import httplib
         httplib.HTTPConnection.debuglevel = 1
     else:
@@ -975,7 +978,7 @@
                 continue
             bconf = boards_config[board_name]
             process_board(board, bconf, args.bug, args.card)
-        except (KeyError, AssertionError) as e:
+        except (KeyError, AssertionError):
             log.exception("Exception caught.  Skipping board.")
             continue
 
 
=== modified file 'src/lp2kanban/cards2workitems.py'
--- src/lp2kanban/cards2workitems.py	2013-06-19 19:44:20 +0000
+++ src/lp2kanban/cards2workitems.py	2016-09-08 22:02:56 +0000
@@ -13,9 +13,9 @@
 # support POSTPONED work items in this mapping, since the Kanban board
 # has no such concept.
 LANE_TYPE_TO_WORK_ITEM_STATUS_MAP = {
-    1: u"TODO", # Kanban type "Ready"
-    2: u"INPROGRESS", # Kanban type "In process"
-    3: u"DONE", # Kanban type "Complete"
+    1: u"TODO",  # Kanban type "Ready"
+    2: u"INPROGRESS",  # Kanban type "In process"
+    3: u"DONE",  # Kanban type "Complete"
     }
 
 
@@ -34,7 +34,7 @@
         card.description_annotations.get('blueprint_url') or
         card.external_system_url)
     if (blueprint_url is None or not
-        blueprint_url_pattern.match(blueprint_url)):
+            blueprint_url_pattern.match(blueprint_url)):
         # Return early if the card isn't linked to a blueprint, since
         # there's no point doing the conversion if we're not going to
         # sync it.
@@ -118,8 +118,8 @@
         work_items_text = "\n".join(work_items)
         blueprint = fetch_blueprint(lp, blueprint_url)
         if blueprint is not None:
-            print "Adding %s work items to %s" % (
-                len(work_items), blueprint.name)
+            print("Adding %s work items to %s" % (
+                len(work_items), blueprint.name))
             blueprint.workitems_text = work_items_text
             blueprint.lp_save()
 
 
=== modified file 'src/lp2kanban/kanban.py'
--- src/lp2kanban/kanban.py	2016-09-08 22:02:56 +0000
+++ src/lp2kanban/kanban.py	2016-09-08 22:02:56 +0000
@@ -3,7 +3,6 @@
 
 import requests
 import json
-import logging
 import operator
 from pprint import pprint
 import re
@@ -112,14 +111,14 @@
 
         resp = request.response
         if (not sent or
-            resp.status_code not in LeankitResponseCodes.SUCCESS_CODES):
-            print "Error from kanban"
+                resp.status_code not in LeankitResponseCodes.SUCCESS_CODES):
+            print("Error from kanban")
             pprint(resp)
             raise IOError('kanban error %d' % (resp.status_code))
         response = Record(json.loads(resp.content))
 
         if (handle_errors and
-            response.ReplyCode not in LeankitResponseCodes.SUCCESS_CODES):
+                response.ReplyCode not in LeankitResponseCodes.SUCCESS_CODES):
             raise IOError('kanban error %d: %s' % (
                 response.ReplyCode, response.ReplyText))
         return response
@@ -166,7 +165,7 @@
     def _prettifyName(self, camelcase):
         camelcase = camelcase.replace('ID', '_id')
         if len(camelcase) > 1:
-            repl_func = lambda match: '_' + match.group(1).lower()
+            def repl_func(match): return '_' + match.group(1).lower()
             camelcase = camelcase[0].lower() + camelcase[1:]
             return re.sub('([A-Z])', repl_func, camelcase)
         else:
@@ -174,7 +173,7 @@
 
     def _toCamelCase(self, name):
         if len(name) > 1:
-            repl_func = lambda match: match.group(1)[1:].upper()
+            def repl_func(match): return match.group(1)[1:].upper()
             name = name[0].upper() + name[1:]
             return re.sub('(_[a-z])', repl_func, name)
         else:
@@ -236,9 +235,9 @@
             # no-op.
             return
         data = self._raw_data
-        data["UserWipOverrideComment"] =  None;
+        data["UserWipOverrideComment"] = None
         if ("AssignedUsers" in data and
-            "assigned_user_id" not in self.dirty_attrs):
+                "assigned_user_id" not in self.dirty_attrs):
             if 'AssignedUserId' in data.keys():
                 del data['AssignedUserId']
             if 'AssignedUserName' in data.keys():
@@ -247,7 +246,6 @@
                 lambda X: X['AssignedUserId'], data['AssignedUsers'])
 
         for attr in self.dirty_attrs:
-            #print "Storing %s in %s..." % (attr, self._toCamelCase(attr))
             data[self._toCamelCase(attr)] = getattr(self, attr)
 
         board_id = str(self.lane.board.id)
@@ -380,7 +378,6 @@
         self.external_card_id = src.external_card_id
         self.assigned_user_id = src.assigned_user_id
 
-
     @property
     def parsed_description(self):
         """Parse the card description to find key=value pairs.
@@ -397,8 +394,8 @@
             end = match.end()
             try:
                 annotations = Record(json.loads(self.description[start:end]))
-            except ValueError, ex:
-                print "Unable to parse card %s: %s" % (self.id, ex.message)
+            except ValueError as ex:
+                print("Unable to parse card %s: %s" % (self.id, ex.message))
                 annotations = Record()
             return (
                 annotations,
@@ -580,7 +577,7 @@
             archive_lanes = [lane_dict['Lane'] for lane_dict in self._archive]
             archive_lanes.extend(
                 [lane_dict['Lane'] for
-                lane_dict in self._archive[0]['ChildLanes']])
+                    lane_dict in self._archive[0]['ChildLanes']])
             lanes += archive_lanes
         lanes += self.connector.get(
             "/Kanban/Api/Board/" + str(self.id) + "/Backlog").ReplyData[0]
@@ -594,7 +591,7 @@
 
     def _classifyCards(self):
         """Classify the cards into buckets for lookups later."""
-        print "   Classifying cards %s cards." % len(self.cards)
+        print("   Classifying cards %s cards." % len(self.cards))
         for card in self.cards:
             if card.type.name == "Feature":
                 self._feature_cards.add(card)
@@ -608,18 +605,18 @@
                 if BRANCH_MP_REGEX.match(card.external_system_url):
                     self._cards_with_branches.add(card)
                 else:
-                    print ("WARNING: Card won't sync. Non-branch link ({}) "
-                           "for {}.".format(url, card.title))
-        print "   - %s feature cards" % len(
-            self._feature_cards)
-        print "   - %s cards with external ids" % len(
-            self._cards_with_external_ids)
-        print "   - %s cards with external links" % len(
-            self._cards_with_external_links)
-        print "   - %s cards with description annotations" % len(
-            self._cards_with_description_annotations)
-        print "   - %s cards with branches" % len(
-            self._cards_with_branches)
+                    print("WARNING: Card won't sync. Non-branch link ({}) "
+                          "for {}.".format(url, card.title))
+        print("   - %s feature cards" % len(
+            self._feature_cards))
+        print("   - %s cards with external ids" % len(
+            self._cards_with_external_ids))
+        print("   - %s cards with external links" % len(
+            self._cards_with_external_links))
+        print("   - %s cards with description annotations" % len(
+            self._cards_with_description_annotations))
+        print("   - %s cards with branches" % len(
+            self._cards_with_branches))
 
     def _populateFeatureTagPaths(self):
         """Create a map from feature tag to the group owning the feature."""
@@ -672,12 +669,13 @@
 
     def getLane(self, lane_id):
         flat_lanes = {}
+
         def flatten_lane(lane):
             flat_lanes[lane.id] = lane
             for child in lane.child_lanes:
                 flatten_lane(child)
         map(flatten_lane, self.root_lane.child_lanes)
-        return flat_lanes[lane_id];
+        return flat_lanes[lane_id]
 
     def getLaneByTitle(self, title):
         if len(self.root_lane.child_lanes) > 0:
@@ -689,7 +687,7 @@
         else:
             for child in lane.child_lanes:
                 result = self._getLaneByTitle(child, title)
-                if result != None:
+                if result is not None:
                     return result
             return None
 
@@ -698,7 +696,7 @@
             return self._getLaneByPath(self.root_lane, path, ignorecase)
 
     def _getLaneByPath(self, lane, path, ignorecase):
-        if ignorecase == True:
+        if ignorecase is True:
             if lane.path.lower() == path.lower():
                 return lane
         else:
@@ -707,24 +705,23 @@
 
         for child in lane.child_lanes:
             result = self._getLaneByPath(child, path, ignorecase)
-            if result != None:
+            if result is not None:
                 return result
         return None
 
-
     def _printLanes(self, lane, indent, include_cards=False):
         next_lane = lane.getNextLanes()
         if next_lane is None:
             next_lane = ''
         else:
             next_lane = (' (next: any of [' +
-                         ', '.join([my_lane.path for my_lane in next_lane])
-                         + '])')
+                         ', '.join([my_lane.path for my_lane in next_lane]) +
+                         '])')
             next_lane += ' - %d cards' % len(lane.cards)
-        print "  " * indent + "* " + lane.title + next_lane
+        print("  " * indent + "* " + lane.title + next_lane)
         for card in lane.cards:
-            print ("  " * (indent + 1) + "- #" + card.external_card_id +
-                   ': ' + card.title)
+            print("  " * (indent + 1) + "- #" + card.external_card_id +
+                  ': ' + card.title)
         for child in lane.child_lanes:
             self._printLanes(child, indent + 1)
 
@@ -732,7 +729,7 @@
         """Recursively prints all the lanes in the board with indentation."""
         if len(self.root_lane.child_lanes) == 0:
             return
-        print "Board lanes:"
+        print("Board lanes:")
         indent = 1
         for lane in self.root_lane.child_lanes:
             self._printLanes(lane, indent, include_cards)
@@ -818,16 +815,16 @@
     kanban = LeankitKanban('launchpad.leankitkanban.com',
                            'user@email', 'password')
 
-    print "Active boards:"
+    print("Active boards:")
     boards = kanban.getBoards()
     for board in boards:
-        print " * %s (%d)" % (board.title, board.id)
+        print(" * %s (%d)" % (board.title, board.id))
 
     # Get a board by the title.
     board_name = 'Landscape 2016'
-    print "Getting board '%s'..." % board_name
+    print("Getting board '%s'..." % board_name)
     board = kanban.getBoard(title=board_name)
     board.printLanes()
 
     # Print all users.
-    print board.users
+    print(board.users)
 
=== modified file 'src/lp2kanban/tests/test_bugs2cards.py'
--- src/lp2kanban/tests/test_bugs2cards.py	2016-09-08 22:02:56 +0000
+++ src/lp2kanban/tests/test_bugs2cards.py	2016-09-08 22:02:56 +0000
@@ -1,8 +1,6 @@
 # Copyright 2011-2012 Canonical Ltd
 """Tests for the bugs2cards.py script."""
 
-__metaclass__ = type
-
 from ConfigParser import (
     ConfigParser,
     NoSectionError,
@@ -38,12 +36,9 @@
     )
 from lp2kanban.kanban import (
     RESOURCE_TYPE_LINK_SERIES,
-    LeankitCard,
     Record,
     )
 from lp2kanban.tests.common import (
-    FauxLeankitUser,
-    FauxLaunchpadUser,
     FauxLaunchpadUsersForBoard,
     FauxBoard,
     FauxCard,
@@ -51,6 +46,8 @@
     FauxLane,
     )
 
+__metaclass__ = type
+
 
 def parse_config_text(text):
     config = ConfigParser()
@@ -90,8 +87,7 @@
         globals, boards = parse_config(config)
 
         self.assertEqual({'var1': 'value1',
-                          'var2': 'value2',
-                           }, globals)
+                          'var2': 'value2'}, globals)
         self.assertEqual({'Board 1': {'var1': 'board value 1'}}, boards)
 
     def test_parse_config_defaults(self):
@@ -131,7 +127,9 @@
 
 
 class FauxMP:
-    def __init__(self, queue_status, target_name, link=None, description=None, date_created=None):
+    def __init__(
+            self, queue_status, target_name, link=None, description=None,
+            date_created=None):
         self.queue_status = queue_status
         self.target_branch = Record(name=target_name)
         self.web_link = link
@@ -145,7 +143,7 @@
         self.projects = data.get("projects", {})
         self.project_group = data.get("project_groups", {})
         self.bugs = data.get("bugs", {})
-    
+
 
 class BranchInfoTests(unittest.TestCase):
 
@@ -296,7 +294,7 @@
     def __init__(self, resource_type_link="http://api/project", project=None):
         self.resource_type_link = resource_type_link
         self.project = project
-   
+
 
 class FauxBugTask:
 
@@ -312,23 +310,25 @@
 class IsBugInProjectsTest(unittest.TestCase):
 
     def test_false_when_part_of_external_project(self):
-        # Return False when the bug is part of an unconfigured (external) project
+        # Return False when the bug is part of an unconfigured (external)
+        # project
         bug = FauxBug()
-        project = FauxTarget(resource_type_link="project", project="otherproject")
+        project = FauxTarget(
+            resource_type_link="project", project="otherproject")
         bug.addTask(project)
         self.assertFalse(is_bug_in_projects(bug, ["myproject1", "myproject2"]))
 
     def test_true_when_part_of_configured_projects(self):
         # Return True when the bug is one of the configured (internal) projects
         bug = FauxBug()
-        project = FauxTarget(resource_type_link="project", project="myproject2")
+        project = FauxTarget(
+            resource_type_link="project", project="myproject2")
         bug.addTask(project)
         self.assertTrue(is_bug_in_projects(bug, ["myproject1", "myproject2"]))
 
-
     def test_true_when_series_within_a_configured_project(self):
-        # Return True when the bug has a series task that is related to one of the
-        # configured projects.
+        # Return True when the bug has a series task that is related to one
+        # of the configured projects.
         bug = FauxBug()
         series = FauxTarget(
             resource_type_link=RESOURCE_TYPE_LINK_SERIES, project="myproject1")
@@ -407,7 +407,8 @@
         # than 'Fix Committed').
         bug = FauxBug()
         project1 = FauxTarget(resource_type_link="project", project="lazr")
-        project2 = FauxTarget(resource_type_link="project", project="launchpad")
+        project2 = FauxTarget(
+            resource_type_link="project", project="launchpad")
         bug.addTask(project1, status='Fix Released')
         bug.addTask(project2, status='In Progress')
         matches, status, assignees, mp_url, mp_type = get_bug_status(
@@ -583,8 +584,9 @@
         self.assertTrue(should_sync_card(card, {'autosync': 'on',
                                                 'sync_cards': 'on'}))
 
-    def test_should_sync_card_autosync_synced_with_external_card_id(self):
-        # When autosync is 'active-projects', cards with external card IDs are synced.
+    def test_should_sync_card_autosync_active_projects_external_card_id(self):
+        # When autosync is 'active-projects', cards with external card
+        # IDs are synced.
         card = Record(title=u'no sync', description=u'',
                       external_card_id=u'11', external_system_url=u'')
         self.assertTrue(should_sync_card(card, {'autosync': 'active-projects',
@@ -663,8 +665,8 @@
         self.assertFalse(should_sync_card(card2, conf))
 
     def test_get_card_status_new_no_branch(self):
-        # For a bug in 'New', 'Triaged' or 'Confirmed' or 'Incomplete' statuses,
-        # the branch status is new state.
+        # For a bug in 'New', 'Triaged' or 'Confirmed' or
+        # 'Incomplete' statuses the branch status is new state.
         no_branch_info = Record(status=None)
         self.assertEqual(
             CardStatus.NEW,
@@ -681,29 +683,29 @@
 
     def test_get_card_status_coding_no_bug(self):
         # For a card with no associated bug, an 'In Progress' branch status
-        # will be in the coding state. 
+        # will be in the coding state.
         branch_info = Record(status='In Progress', target=None)
         self.assertEqual(
-            CardStatus.CODING, 
+            CardStatus.CODING,
             get_card_status(None, [], branch_info))
 
     def test_get_card_status_review_no_bug(self):
         # For a card with no associated bug, an 'Approved' or 'In Review'
-        # branch status will be in the review state. 
+        # branch status will be in the review state.
         branch_infos = [
             Record(status='In Review', target=None),
             Record(status='Approved', target=None)]
         for branch_info in branch_infos:
             self.assertEqual(
-                CardStatus.REVIEW, 
+                CardStatus.REVIEW,
                 get_card_status(None, [], branch_info))
 
     def test_get_card_status_landing_no_bug(self):
         # For a card with no associated bug, a merged branch status will be in
-        # the landing state. 
+        # the landing state.
         branch_info = Record(status='Merged', target=None)
         self.assertEqual(
-            CardStatus.LANDING, 
+            CardStatus.LANDING,
             get_card_status(None, [], branch_info))
 
     def test_get_card_status_coding_in_progress_no_branch(self):
@@ -888,7 +890,7 @@
         cards = get_cards_for_feature(
             self.feature_card, self.feature_bug, card_type='Branch')
         self.assertItemsEqual([branch_card], cards)
-      
+
 
 class FindLaneNextTest(unittest.TestCase):
 
@@ -980,7 +982,7 @@
     def test_no_bugs(self):
         # If no bugs are found, no cards are created.
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
+        board.addLane('bugs')
         project = FauxLaunchpadProject(bug_tasks=[])
         create_cards_in_project(board, project, 'kanban')
         self.assertEqual([], board.cards)
@@ -989,7 +991,7 @@
         # If a new bug is found, a card is created for it, having the
         # bug id, title and description saved.
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
+        board.addLane('bugs')
         project = FauxLaunchpadProject(
             bug_tasks=[FauxBugTask(
                            bug_id=42, title='Test bug',
@@ -1007,7 +1009,7 @@
         # After a card is created from a bug, the bug tag is removed, so
         # that having a lot of open bugs won't slow down the process.
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
+        board.addLane('bugs')
         project = FauxLaunchpadProject(
             bug_tasks=[FauxBugTask(
                            bug_id=42, title='Test bug',
@@ -1038,7 +1040,7 @@
         # Cards are created only for bugs having the bug tag that is
         # passed in to create_cards_in_project().
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
+        board.addLane('bugs')
         project = FauxLaunchpadProject(
             bug_tasks=[FauxBugTask(
                            bug_id=21, title='Tagged with other tag',
@@ -1058,7 +1060,7 @@
         # It's possible to specify which card type that the created card
         # should have, instead of the default one.
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
+        board.addLane('bugs')
         project = FauxLaunchpadProject(
             bug_tasks=[FauxBugTask(
                            bug_id=42, title='Test bug',
@@ -1066,7 +1068,8 @@
                            tags=['kanban'])])
         feature_type = FauxCardType(id=2, name='Feature', is_default=False)
         board.cardtypes[feature_type.id] = feature_type
-        create_cards_in_project(board, project, 'kanban', cardtype_name='Feature')
+        create_cards_in_project(
+            board, project, 'kanban', cardtype_name='Feature')
         [card] = board.cards
         self.assertEqual(feature_type.id, card.type_id)
         self.assertTrue(card.saved)
@@ -1075,8 +1078,8 @@
         # It's possible to specify to which lane the card should be
         # added.
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
-        bug_lane = board.addLane('incoming')
+        board.addLane('bugs')
+        board.addLane('incoming')
         project = FauxLaunchpadProject(
             bug_tasks=[FauxBugTask(
                            bug_id=42, title='Test bug',
@@ -1094,7 +1097,7 @@
         # Bug descriptions that exceed the 19997 character limit of a
         # kanban card are truncated to 19500 bytes.
         board = FauxBoard()
-        bug_lane = board.addLane('bugs')
+        board.addLane('bugs')
         project = FauxLaunchpadProject(
             bug_tasks=[FauxBugTask(
                            bug_id=42, title='Test bug',
@@ -1185,7 +1188,6 @@
             parse_groups_config(config))
 
 
-
 class LaunchpadUsersForBoardTest(unittest.TestCase):
 
     def setUp(self):
@@ -1266,12 +1268,12 @@
         lp_users = LaunchpadUsersForBoard()
         lp_users.set_up_users(lp, board, config)
         self.assertEqual(
-            {"sometag": coding_lane, "anothertag": coding_lane}, 
+            {"sometag": coding_lane, "anothertag": coding_lane},
             lp_users.feature_lanes)
 
     def test_feature_lanes_unset_with_group_new_lanes_and_no_assignee(self):
         # When a feature card is present and tagged and the new_lanes
-        # in the config specifies the ${group} variable, 
+        # in the config specifies the ${group} variable,
         # feature_lanes will be unset when there are no assigned users on the
         # card.
         feature_card = FauxCard(tags="sometag")
@@ -1305,7 +1307,8 @@
         lp = None
         config = {"groups_config_file": groups_file.name,
                   "new_lanes": "dev::${group}::coding"}
-        lp_users = LaunchpadUsersForBoard(kanban_to_lp={1:FauxPerson("User1")})
+        lp_users = LaunchpadUsersForBoard(
+            kanban_to_lp={1: FauxPerson("User1")})
         lp_users.set_up_users(lp, board, config)
         self.assertEqual(
             {"squad-group-1": coding_lane, "squad-group-2": coding_lane2},
@@ -1313,7 +1316,7 @@
 
     def test_feature_lanes_set_with_group_new_lanes_and_assignee(self):
         # When a feature card is present and tagged and the new_lanes
-        # in the config specifies the ${group} variable, 
+        # in the config specifies the ${group} variable,
         # feature_lanes will be set when there are is an assigned user on the
         # card.
         feature_card = FauxCard(tags="sometag,anothertag")
@@ -1336,17 +1339,17 @@
         lp = None
         config = {"groups_config_file": groups_file.name,
                   "new_lanes": "dev::${group}::coding"}
-        lp_users = LaunchpadUsersForBoard(kanban_to_lp={1:FauxPerson("User1")})
+        lp_users = LaunchpadUsersForBoard(
+            kanban_to_lp={1: FauxPerson("User1")})
         lp_users.set_up_users(lp, board, config)
         self.assertEqual(
-            {"sometag": coding_lane, "anothertag": coding_lane, 
-             "squad-group-1": coding_lane, "squad-group-2": coding_lane2}, 
+            {"sometag": coding_lane, "anothertag": coding_lane,
+             "squad-group-1": coding_lane, "squad-group-2": coding_lane2},
             lp_users.feature_lanes)
 
 
 class FauxPerson:
 
-
     def __init__(self, name):
         self.name = name
 
@@ -1654,7 +1657,7 @@
         self.lp_users = FauxLaunchpadUsersForBoard()
 
     def test_sync_cards_moves_landing_cards_to_taskboard_in_landing_lane(self):
-    	"""
+        """
         Feature-linked cards in landing lanes will move to taskboard when the
         feature card is in landing_lanes.
         """
@@ -1735,16 +1738,20 @@
         self.assertEqual((self.feature_card, 'Done'), landed_card2.moved_to)
 
     def test_sync_cards_external_ids_filter_card(self):
-    	"""filter_card skips and selects correctly."""
-        # Configure bugs2cards to sync only active-projects myproject1 and myproject2
+        """filter_card skips and selects correctly."""
+        # Configure bugs2cards to sync only active-projects myproject1
+        # and myproject2
         self.bconf.update({
             "autosync": "active-projects",
             "projects": "myproject",
             "sync_cards": "on", "move_cards": "on",
             "new_lanes": "new"})
-        # Setup bug1 and bug2 in separate projects which both need to move coding -> new
-        project1 = FauxTarget(resource_type_link="project", project="myproject")
-        lp_users = FauxLaunchpadUsersForBoard(lp_to_kanban={"person1": "Person One"})
+        # Setup bug1 and bug2 in separate projects which both need to
+        # move coding -> new
+        project1 = FauxTarget(
+            resource_type_link="project", project="myproject")
+        lp_users = FauxLaunchpadUsersForBoard(
+            lp_to_kanban={"person1": "Person One"})
         lp_projects = [project1]
         bug_task1 = FauxBugTask(
             bug_id=123, target=project1, title='Test bug in myproject',
@@ -1766,25 +1773,31 @@
         bug_card1.type = bug_type
         bug_card2.type = bug_type
         self.board.cards.extend([bug_card1, bug_card2])
-        lp = FauxLP({"projects": {"myproject": project1},
-                 "bugs": {123: bug_task1.bug, 456: bug_task2.bug}})
+        lp = FauxLP({
+            "projects": {"myproject": project1},
+            "bugs": {123: bug_task1.bug, 456: bug_task2.bug}})
         sync_cards_external_ids(
-            board, self.bconf, lp, lp_users, lp_projects, filter_card=bug_card2.id)
+            board, self.bconf, lp, lp_users,
+            lp_projects, filter_card=bug_card2.id)
         coding_lane = FauxLane(board=board, path='coding')
         self.assertEqual(new_lane, bug_card2.moved_to)
         self.assertIsNone(bug_card1.moved_to)
 
     def test_sync_cards_skips_bugs_not_in_filter_bug(self):
-    	"""filter_bug skips and selects bugs in sync_cards_external_ids."""
-        # Configure bugs2cards to sync only active-projects myproject1 and myproject2
+        """filter_bug skips and selects bugs in sync_cards_external_ids."""
+        # Configure bugs2cards to sync only active-projects myproject1
+        # and myproject2
         self.bconf.update({
             "autosync": "active-projects",
             "projects": "myproject",
             "sync_cards": "on", "move_cards": "on",
             "new_lanes": "new"})
-        # Setup bug1 and bug2 in separate projects which both need to move coding -> new
-        project1 = FauxTarget(resource_type_link="project", project="myproject")
-        lp_users = FauxLaunchpadUsersForBoard(lp_to_kanban={"person1": "Person One"})
+        # Setup bug1 and bug2 in separate projects which both need
+        # to move coding -> new
+        project1 = FauxTarget(
+            resource_type_link="project", project="myproject")
+        lp_users = FauxLaunchpadUsersForBoard(
+            lp_to_kanban={"person1": "Person One"})
         lp_projects = [project1]
         bug_task1 = FauxBugTask(
             bug_id=123, target=project1, title='Test bug in myproject',
@@ -1806,26 +1819,34 @@
         bug_card1.type = bug_type
         bug_card2.type = bug_type
         self.board.cards.extend([bug_card1, bug_card2])
-        lp = FauxLP({"projects": {"myproject": project1},
-                 "bugs": {123: bug_task1.bug, 456: bug_task2.bug}})
+        lp = FauxLP({
+            "projects": {"myproject": project1},
+            "bugs": {123: bug_task1.bug, 456: bug_task2.bug}})
         sync_cards_external_ids(
             board, self.bconf, lp, lp_users, lp_projects, filter_bug=u"456")
         coding_lane = FauxLane(board=board, path='coding')
         self.assertEqual(new_lane, bug_card2.moved_to)
         self.assertIsNone(bug_card1.moved_to)
 
-    def test_sync_cards_skips_bugs_of_external_projects_when_active_projects_set(self):
-    	"""Bugs of external projects are skipped when autosync set to active-projects."""
-        # Configure bugs2cards to sync only active-projects myproject1 and myproject2
+    def test_sync_cards_skips_bugs_of_external_projects_active_projects(self):
+        """Bugs of external projects are skipped when autosync set to
+        active-projects."""
+        # Configure bugs2cards to sync only active-projects myproject1
+        # and myproject2
         self.bconf.update({"autosync": "active-projects",
                            "projects": "myproject,myproject2",
                            "sync_cards": "on", "move_cards": "on",
                            "new_lanes": "new"})
-        # Setup bug1 and bug2 in separate projects which both need to move coding -> new
-        project1 = FauxTarget(resource_type_link="project", project="myproject")
-        project2 = FauxTarget(resource_type_link="project2", project="myproject2")
-        otherproject = FauxTarget(resource_type_link="project", project="otherproject")
-        lp_users = FauxLaunchpadUsersForBoard(lp_to_kanban={"person1": "Person One"})
+        # Setup bug1 and bug2 in separate projects which both need to move
+        # coding -> new
+        project1 = FauxTarget(
+            resource_type_link="project", project="myproject")
+        project2 = FauxTarget(
+            resource_type_link="project2", project="myproject2")
+        otherproject = FauxTarget(
+            resource_type_link="project", project="otherproject")
+        lp_users = FauxLaunchpadUsersForBoard(
+            lp_to_kanban={"person1": "Person One"})
         lp_projects = [project1, project2]
         bug_task1 = FauxBugTask(
             bug_id=123, target=project1, title='Test bug in myproject',
@@ -1848,8 +1869,9 @@
         bug_card2.type = bug_type
         self.board.cards.extend([bug_card1, bug_card2])
         # Include project1 and project2 in our active 'projects' fake LP data
-        lp = FauxLP({"projects": {"myproject": project1, "myproject2": project2},
-                 "bugs": {123: bug_task1.bug, 456: bug_task2.bug}})
+        lp = FauxLP({
+            "projects": {"myproject": project1, "myproject2": project2},
+            "bugs": {123: bug_task1.bug, 456: bug_task2.bug}})
         sync_cards_external_ids(board, self.bconf, lp, lp_users, lp_projects)
         coding_lane = FauxLane(board=board, path='coding')
         self.assertEqual(new_lane, bug_card1.moved_to)
 
=== modified file 'src/lp2kanban/tests/test_cards2workitems.py'
--- src/lp2kanban/tests/test_cards2workitems.py	2013-03-19 16:06:09 +0000
+++ src/lp2kanban/tests/test_cards2workitems.py	2016-09-08 22:02:56 +0000
@@ -1,5 +1,4 @@
 # Copyright 2012 Canonical Ltd.
-__metaclass__ = type
 
 import re
 import testtools
@@ -27,6 +26,8 @@
 from testtools.monkey import patch
 from textwrap import dedent
 
+__metaclass__ = type
+
 
 class CardsToWorkItemsBase(testtools.TestCase):
 
@@ -56,9 +57,9 @@
             "String \"{string}\" did not match pattern \"{pattern}\"".format(
                 string=string, pattern=pattern))
 
-    def _generateCard(self, board=None, lane=None,
-                     description_annotations=None, assigned_user_id=0,
-                     title=None, external_system_url=None):
+    def _generateCard(
+            self, board=None, lane=None, description_annotations=None,
+            assigned_user_id=0, title=None, external_system_url=None):
         if board is None:
             board = self.board
         if lane is None:
@@ -220,7 +221,8 @@
         work_item = convert_card_to_work_item(
             card, self.board, self.lp_users_for_board)
         self.assertEqual(
-            card.description_annotations.blueprint_url, work_item.blueprint_url)
+            card.description_annotations.blueprint_url,
+            work_item.blueprint_url)
 
     def test_blueprint_extracted_from_card_external_link(self):
         # Cards can also be linked to blueprints by putting the
@@ -233,7 +235,7 @@
             external_system_url=self.blueprint_url,
             description_annotations=Record(),
             )
-        work_item = convert_card_to_work_item(
+        convert_card_to_work_item(
             card, self.board, self.lp_users_for_board)
         self.assertEqual(
             self.blueprint_url, card.description_annotations.blueprint_url)
@@ -243,8 +245,8 @@
         # isn't a blueprint, convert_card_to_work_item() will return
         # None.
         card = self._generateCard(
-            description_annotations=Record
-                (blueprint_url= 'https://nyancat.com'))
+            description_annotations=Record(
+                blueprint_url='https://nyancat.com'))
         work_item = convert_card_to_work_item(
             card, self.board, self.lp_users_for_board)
         self.assertIsNone(work_item)
@@ -268,8 +270,8 @@
             self._generateCard(
                 title="Card %i" % id,
                 description_annotations=Record(
-                    blueprint_url=blueprint_url_tpl % id))
-                for id in range(3)]
+                    blueprint_url=blueprint_url_tpl % id
+                    )) for id in range(3)]
         self.work_items = convert_cards_to_work_items(
             self.cards, self.board, self.lp_users_for_board)
         self.blueprints = {}
@@ -283,6 +285,7 @@
         # We stub out the Launchpad interaction using a fake version of
         # fetch_blueprint()
         called_with_urls = []
+
         def fake_fetch_blueprint(lp, url):
             called_with_urls.append(url)
             return FauxBlueprint(name="somename")
 
=== modified file 'src/lp2kanban/tests/test_description_annotations.py'
--- src/lp2kanban/tests/test_description_annotations.py	2013-03-18 13:25:36 +0000
+++ src/lp2kanban/tests/test_description_annotations.py	2016-09-08 22:02:56 +0000
@@ -9,6 +9,7 @@
 from textwrap import dedent
 import unittest
 
+
 class DescriptionAnnotationsTest(unittest.TestCase):
     """Tests for kanban.LeankitCard description annotations."""
 
@@ -16,7 +17,7 @@
         # parse_card_description() parses key:value pairs out of a
         # card's description and returns them as a dict.
         card = LeankitCard.create(FauxLane("Test"))
-        card.title=u"some card"
+        card.title = u"some card"
         card.description = dedent("""
         {"key2": "value2", "key1": "value 1"}
         """)
@@ -28,7 +29,7 @@
         # Any text not in the key=value form is returned unparsed by
         # card.parsed_description().
         card = LeankitCard.create(FauxLane("Test"))
-        card.title=u"some card"
+        card.title = u"some card"
         card.description = dedent("""
             Some other text,
             {"key2": "value2", "key1": "value 1"}
@@ -44,7 +45,7 @@
         # LeankitCard.description_annotations returns only the key=value
         # pairs from the description field.
         card = LeankitCard.create(FauxLane("Test"))
-        card.title=u"some card"
+        card.title = u"some card"
         card.description = dedent("""
             {"key2": "value2", "key1": "value 1"}
             Here's a URL: http://test.com?a=b
@@ -57,7 +58,7 @@
         # LeankitCard._setDescriptionAnnotations() can be used to write
         # new annotations to the description field.
         card = LeankitCard.create(FauxLane("Test"))
-        card.title=u"some card"
+        card.title = u"some card"
         card.description = dedent("""
             Some text
             {"key2": "value2", "key1": "value 1"}
@@ -73,7 +74,7 @@
         # LeankitCard.description_annotations is a Record, so it hass
         # attribute access for its values.
         card = LeankitCard.create(FauxLane("Test"))
-        card.title=u"some card"
+        card.title = u"some card"
         card.description = '{"key1": "value 1"}'
         self.assertIsInstance(card.description_annotations, Record)
         self.assertEqual("value 1", card.description_annotations.key1)
 
=== modified file 'src/lp2kanban/workitems2cards.py'
--- src/lp2kanban/workitems2cards.py	2013-03-18 13:42:24 +0000
+++ src/lp2kanban/workitems2cards.py	2016-09-08 22:02:56 +0000
@@ -66,8 +66,8 @@
             assigned_user_id = assigned_user.id
         else:
             assigned_user_id = 0
-        print "Creating card {title} [{assignee}]".format(
-            title=work_item.text, assignee=assigned_user_id)
+        print(u"Creating card {title} [{assignee}]".format(
+            title=work_item.text, assignee=assigned_user_id))
         card = lane.addCard()
         card.title = work_item.text
         card.description_annotations.blueprint_url = work_item.blueprint
@@ -90,15 +90,15 @@
 
     match = re.match(BLUEPRINT_URL_PATTERN, args.spec_url)
     if match is None:
-        print "Spec URL is not a Launchpad blueprint."
+        print("Spec URL is not a Launchpad blueprint.")
         sys.exit(1)
 
     if not args.dry_run:
-        should_continue = raw_input(
+        should_continue = raw_input(  # noqa
             "WARNING: This script is not well-tested and will mess with "
             "your Kanban board; use it at your own risk. Continue? [y/N] ")
         if should_continue.lower() != "y":
-            print "Exiting."
+            print("Exiting.")
             sys.exit(0)
 
     match_dict = match.groupdict()
@@ -115,17 +115,17 @@
         sys.exit(1)
     work_items = parse_work_items(lp, **match_dict)
     if not args.dry_run:
-        should_continue = raw_input(
+        should_continue = raw_input(  # noqa
             "{count} cards will be created, whether or not you want them all. "
             "Continue [y/N]?".format(count=len(work_items)))
     if args.dry_run or should_continue.lower() == "y":
-        print "Creating cards from work items in lane {lane}.".format(
-            lane=args.target_lane)
+        print(u"Creating cards from work items in lane {lane}.".format(
+            lane=args.target_lane))
         cards = work_items_to_cards(
             work_items, board, lane, lp_users, dry_run=args.dry_run)
-        print "{count} cards created".format(count=len(cards))
+        print(u"{count} cards created").format(count=len(cards))
     else:
-        print "Aborting."
+        print(u"Aborting.")
 
 if __name__ == '__main__':
     main(sys.argv)