Code review comment for lp:~dpb/latch-test/dont-be-so-verbose

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Thanks for pushing an MP for this David, looks like a good change to me.

Re testing, yes, my recommendation is to avoid mocks, but since these tests already make use of them, it seems out of scope to fix that here, so +1

Unrelated comment, but it seems to me that it's not possible (or it would be very awkward) to save artifacts generated by latch-test, because of this code in test_cli:

        with temporary_directory() as temp_dir:
            environment.initialize(temp_dir)
            result = environment.execute_test()

which essentially purge everything after tests have run. Would it be possible to add support for specifying an artifacts directory path inside the temporary directory that will moved or copied to the working directory before purging everything? This way we can attach more state information about failed tests using Jenkins artifacts (something that is now pressing because of some flaky integration tests).

review: Approve

« Back to merge proposal