Code review comment for lp:~dpb/charms/precise/apache2/vhost-config-relation

David,

Thank you for this high quality submission! I've tested this with a quick and dirty charm created in python that base64 encodes a jinja2 template and base64 encodes it according to the readme documentation.

It would be great if there were more details with specific details on how to plug this into a charm such as here is the jinja2 vhost template for a basic HTML site being served from /var/www/static - and associated example configuration to do so.

With that being said, the tests pass and it took ~ 20 minutes to write/configure/validate the addition. It performs really well from my perspective.

Thanks again! +1

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>