Code review comment for lp:~dpb/charm-tools/fix-test-env-1271745

Revision history for this message
David Britton (dpb) wrote :

On Fri, Jan 24, 2014 at 3:47 PM, Marco Ceppi <email address hidden> wrote:

> Review: Needs Fixing
>
> I don't like that this sets /all/ the environment variables. I'd rather
> there be a whitelist of environment variables to pass to the tests as the
> testing environment will have very limited scope of env variables.
>

Fixed with corresponding test cases.

--
David Britton <email address hidden>

« Back to merge proposal