Code review comment for lp:~dpb/charm-tools/fix-test-env-1271745

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I don't like that this sets /all/ the environment variables. I'd rather there be a whitelist of environment variables to pass to the tests as the testing environment will have very limited scope of env variables.

review: Needs Fixing

« Back to merge proposal