Code review comment for lp:~doxxx/bzr/quiet-serve

Revision history for this message
Gordon Tyler (doxxx) wrote :

> Also note that if you are using a subprocess that you are going to kill,
> then you need to skip the test on windows so it doesn't hang. (At least
> until a patch comes along that can use TerminateProcess :)

Note that it says "skip_if_plan_to_signal=True", which means skip on win32 until my other patch lands. ;)

« Back to merge proposal