Looks OK for me, though I can't comment on your change to existing test. Maybe second voice from core dev is needed. I can say that I've tested it and it works. Thank you for fixing it so fast.
Also, I'd like to have this patch backported to bzr 2.5.1, because it clearly fixed bug and don't change anything public.
Looks OK for me, though I can't comment on your change to existing test. Maybe second voice from core dev is needed. I can say that I've tested it and it works. Thank you for fixing it so fast.
Also, I'd like to have this patch backported to bzr 2.5.1, because it clearly fixed bug and don't change anything public.
And you need NEWS message, I guess ;-)