Code review comment for lp:~doxxx/bzr/534787-pull-lp-in-config

Revision history for this message
Andrew Bennetts (spiv) wrote :

The combined branch (including my tweak to NEWS, <lp:~spiv/bzr/534787-pull-lp-in-config>) is failing tests:

======================================================================
FAIL: bzrlib.tests.test_urlutils.TestUrlToPath.test_is_url
----------------------------------------------------------------------
_StringException: Text attachment: log
------------

------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/andrew/warthogs/bzr/534787-pull-lp-in-config/bzrlib/tests/test_urlutils.py", line 211, in test_is_url
    self.assertTrue(urlutils.is_url('C:/foo/bar'))
AssertionError
------------

review: Needs Fixing

« Back to merge proposal