Code review comment for lp:~doxxx/bzr/534787-pull-lp-in-config

Revision history for this message
Andrew Bennetts (spiv) wrote :

 review approve

> This fixes bug 534787 by fixing how get_transport tests whether a base path is
> actually a URL in its convert_path_to_url function.

Looks good. Only one tweak:

[...]
> +* ``bzr pull`` now works when a lp: URL is explicitly defined as the parent
> + or pull location in locations.conf or branch.conf. (Gordon Tyler)

This NEWS entry should include the bug number. I'll fix that and land it (as
the prerequisite branch is now approved).

Thanks!

review: Approve

« Back to merge proposal