Code review comment for lp:~doxxx/bzr/392428

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gordon Tyler wrote:
> I've fixed various tests, restoring some to their original state since they should work now with single quotes parsing enabled.
>
> There was also a compatibility problem with Python 2.5 in the cleanup changes I made to get_unicode_argv, which I didn't notice until now because I normally use Python 2.6.

I don't really know about "use_last_error", but I'll also note that we
manually build up a prototype, but I can do

func = ctypes.windll.kernel32.GetCommandLineW

and get a _FuncPtr object in both python2.5 and 2.6. (In 2.4 you need to
install ctypes manually, and we don't use it for the standard Windows
installer anyway.)

I'm wondering what we are gaining by creating our own prototype.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktPXqgACgkQJdeBCYSNAAMOdgCeLpCrOLWeHSwMhYuf/sCcZUX9
/2QAoLdKmiwp12xZ24RQLra7vLFtfgge
=casy
-----END PGP SIGNATURE-----