Code review comment for lp:~dorins/qbzr/qdiff-changes

Revision history for this message
Alexander Belchenko (bialix) wrote :

I've tested new qdiff but I haven't inspected every single line of your changes.

In the future please avoid unnecessary whitespace-only changes in contribution to QBzr. It breaks annotations and makes the review (without qdiff -w) much harder.

Also I wonder if we want to save state of "Ignore whitespace" knob in some config file (maybe in qbzr.conf or branch.conf) but I'm not sure yet. If you have any opinion on this we can discuss it in our google group ML.

Resume: many thanks for great work to you and Glenjamin. I'm going to land it to trunk and will release 0.21 beta1 soon so many people will have a chance to test it in the action.

review: Approve

« Back to merge proposal