Code review comment for lp:~dooferlad/offspring/linaro_offspring_add_bzr_ssh

On Mon, 03 Oct 2011 14:40:28 -0000, Guilherme Salgado <email address hidden> wrote:
> But I don't think we'll ever want to share home directories across
> slaves because that could allow a rogue job to taint others or have
> access to private information. I think it's safe to assume the slaves
> don't share anything other than an NFS mount where they put the built
> artifacts.
>
> I'm CCing James W. to confirm.

That I'm not 100% sure on. Probably worth asking Cody or IS.

Multiple builds will be serialised to the same slave, so there is
certainly sharing of homedirs there, but reliably cleaning up after a
build would avoid problems with that, if it can indeed be done reliably.

Is even having access to the build artefacts going to be an issue for
member services?

Also, while I remember, be sure to take note of the added dependencies
when requesting a rollout of this code, as if e.g. ssh-agent is missing
on a machine where it needs to be it may break existing builds.

> That was my concern, but on a second thought, that shouldn't be possible
> as Offspring should not run any commands other than what's in the build
> script (IIUC). Although it might be possible to, say, craft a hwpack
> config that causes linaro-hwpack-create to run something else.

If this is used for building images with live-build, then that is
trivially possible.

Thanks,

James