Merge lp:~dooferlad/linaro-license-protection/remove-direct-license-references into lp:~linaro-automation/linaro-license-protection/trunk

Proposed by James Tunnicliffe
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 81
Merge reported by: James Tunnicliffe
Merged at revision: not available
Proposed branch: lp:~dooferlad/linaro-license-protection/remove-direct-license-references
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 40 lines (+3/-9)
2 files modified
.htaccess (+0/-6)
tests/test_click_through_license.py (+3/-3)
To merge this branch: bzr merge lp:~dooferlad/linaro-license-protection/remove-direct-license-references
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Review via email: mp+111195@code.launchpad.net

Description of the change

Stop directly fetching license html files - always use license.php

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.htaccess'
--- .htaccess 2012-05-30 02:38:21 +0000
+++ .htaccess 2012-06-20 11:37:19 +0000
@@ -30,9 +30,6 @@
3030
31## If license file is requested, and a download has been requested previously,31## If license file is requested, and a download has been requested previously,
32## pass through to the license file.32## pass through to the license file.
33RewriteCond %{REQUEST_URI} /licenses/ste.html$ [OR]
34RewriteCond %{REQUEST_URI} /licenses/samsung.html$ [OR]
35RewriteCond %{REQUEST_URI} /licenses/linaro.html$ [OR]
36RewriteCond %{REQUEST_URI} /licenses/nolicense.html$ [OR]33RewriteCond %{REQUEST_URI} /licenses/nolicense.html$ [OR]
37RewriteCond %{REQUEST_URI} /licenses/license.php$34RewriteCond %{REQUEST_URI} /licenses/license.php$
38RewriteCond %{HTTP_COOKIE} downloadrequested35RewriteCond %{HTTP_COOKIE} downloadrequested
@@ -41,9 +38,6 @@
4138
42## When license files are requested directly, forward to39## When license files are requested directly, forward to
43## the snapshots.l.o site itself.40## the snapshots.l.o site itself.
44RewriteCond %{REQUEST_URI} /licenses/linaro.html$ [OR]
45RewriteCond %{REQUEST_URI} /licenses/samsung.html$ [OR]
46RewriteCond %{REQUEST_URI} /licenses/ste.html$ [OR]
47RewriteCond %{REQUEST_URI} /licenses/license.php$41RewriteCond %{REQUEST_URI} /licenses/license.php$
48RewriteCond %{HTTP_COOKIE} !downloadrequested=(.*)42RewriteCond %{HTTP_COOKIE} !downloadrequested=(.*)
49RewriteRule .* / [R,L]43RewriteRule .* / [R,L]
5044
=== modified file 'tests/test_click_through_license.py'
--- tests/test_click_through_license.py 2012-06-18 12:45:39 +0000
+++ tests/test_click_through_license.py 2012-06-20 11:37:19 +0000
@@ -19,9 +19,9 @@
1919
20host = 'http://127.0.0.1'20host = 'http://127.0.0.1'
21port = '0' # 0 == Pick a free port.21port = '0' # 0 == Pick a free port.
22samsung_license_path = '/licenses/samsung.html'22samsung_license_path = '/licenses/license.php'
23ste_license_path = '/licenses/ste.html'23ste_license_path = '/licenses/license.php'
24linaro_license_path = '/licenses/linaro.html'24linaro_license_path = '/licenses/license.php'
25samsung_test_file = '/android/~linaro-android/staging-origen/test.txt'25samsung_test_file = '/android/~linaro-android/staging-origen/test.txt'
26ste_test_file = ('/android/~linaro-android/staging-snowball'26ste_test_file = ('/android/~linaro-android/staging-snowball'
27 '/173/target/product/snowball/test.txt')27 '/173/target/product/snowball/test.txt')

Subscribers

People subscribed via source and target branches