Code review comment for lp:~dooferlad/linaro-license-protection/just_use_bzr

Revision history for this message
Данило Шеган (danilo) wrote :

Too fast:

$ scripts/update-deployment.py -vvv settings_staging_snapshots
2012-08-23 20:35:24,791 DEBUG: stdout:
Using saved parent location: http://bazaar.launchpad.net/~linaro-infrastructure/linaro-license-protection/trunk/
 Now on revision 116.
2012-08-23 20:35:24,792 DEBUG: stderr:
 M scripts/linaroscript.py
  M scripts/update-deployment.py
 All changes applied successfully.
Traceback (most recent call last):
  File "scripts/update-deployment.py", line 137, in <module>
    script.run()
  File "/home/danilo/linaro/linaro-license-protection/just_use_bzr/scripts/linaroscript.py", line 45, in run
    self.work()
  File "scripts/update-deployment.py", line 124, in work
    self.refresh_branch(code_root)
  File "scripts/update-deployment.py", line 66, in refresh_branch
    self.run_subcommand(["bzr", "up"], working_tree_dir)
NameError: global name 'working_tree_dir' is not defined

Should be s/working_tree_dir/branch_dir/.

Approved with that caveat.

review: Approve

« Back to merge proposal