Code review comment for lp:~dooferlad/linaro-license-protection/add_api

Revision history for this message
Milo Casagrande (milo) wrote :

Hi James, thanks for working on this.

It looks to go for me.
A couple of things that can be fixed during merge:

216 +# Generate the URL that will return the license information. This is the URL
217 +# if the file with /api/license prepended to the path.

I guess there is a small type there: s/if the file/of the file

Another thing that might be good is to add something in the HACKING file about the new changes/API.

review: Approve

« Back to merge proposal